Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Deprecate] Setting explicit version on analysis component #1978

Merged
merged 2 commits into from
Jan 27, 2022
Merged

[Deprecate] Setting explicit version on analysis component #1978

merged 2 commits into from
Jan 27, 2022

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Jan 26, 2022

Lucene 9 removes the ability to define an explicit version on an analysis component. In this PR the version parameter for an analysis component is deprecated at parse time and a warning issued to the user through the deprecation logger. A separate PR will completely remove the parameter in 2.0.0

@nknize
[Deprecate] Setting explicit version on analysis component
4d3350a 
Lucene 9 removes the ability to define an explicit version on an analysis
component. The version parameter is deprecated at parse time and a warning is
issued to the user through the deprecation logger.

Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize nknize added v2.0.0 Version 2.0.0 non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues deprecate labels Jan 26, 2022
@nknize nknize requested a review from a team as a code owner January 26, 2022 20:11
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@nknize
spotlessApply
da69ad5 
Signed-off-by: Nicholas Walter Knize <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 4d3350a
Log 2064

Reports 2064

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure da69ad5
Log 2066

Reports 2066

@nknize
Copy link
Collaborator Author

nknize commented Jan 26, 2022

Another #1957 failure unrelated to this PR. Adding to #1715

  2> REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.cluster.routing.MovePrimaryFirstTests.testClusterGreenAfterPartialRelocation" -Dtests.seed=1A5D9D8511119DE0 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=hr-HR -Dtests.timezone=Europe/Busingen -Druntime.java=17

  2> java.lang.AssertionError: timed out waiting for green state
        at __randomizedtesting.SeedInfo.seed([1A5D9D8511119DE0:4997F9E03A55E2F4]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureColor(OpenSearchIntegTestCase.java:986)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:925)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:914)
        at org.opensearch.cluster.routing.MovePrimaryFirstTests.testClusterGreenAfterPartialRelocation(MovePrimaryFirstTests.java:67)

@nknize
Copy link
Collaborator Author

nknize commented Jan 26, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success da69ad5
Log 2069

Reports 2069

adnapibar
adnapibar approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@adnapibar adnapibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
minor question though same as on the other PR #1981 - which release we plan to deprecate this?

@nknize
Copy link
Collaborator Author

nknize commented Jan 27, 2022

LGTM minor question though same as on the other PR #1981 - which release we plan to deprecate this?

1.3. I'll backport to 1.x and open a removal PR to remove in main.

@nknize nknize merged commit 0f3b72b into opensearch-project:main Jan 27, 2022
@nknize nknize added the pending backport Identifies an issue or PR that still needs to be backported label Jan 27, 2022
nknize added a commit to nknize/OpenSearch that referenced this pull request Jan 27, 2022
@nknize
[Deprecate] Setting explicit version on analysis component (opensearc…
11c578b 
…h-project#1978)

Lucene 9 removes the ability to define an explicit version on an analysis
component. The version parameter is deprecated at parse time and a warning is
issued to the user through the deprecation logger.

Signed-off-by: Nicholas Walter Knize <[email protected]>
This was referenced Jan 27, 2022
Merged
Merged
dblock pushed a commit that referenced this pull request Feb 2, 2022
@nknize
[Deprecate] Setting explicit version on analysis component (#1978) (#…
65f12d8 
…1985)

Lucene 9 removes the ability to define an explicit version on an analysis
component. The version parameter is deprecated at parse time and a warning is
issued to the user through the deprecation logger.

Signed-off-by: Nicholas Walter Knize <[email protected]>
@dreamer-89 dreamer-89 mentioned this pull request Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnapibar adnapibar adnapibar approved these changes

Assignees
No one assigned
Labels
deprecate non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues pending backport Identifies an issue or PR that still needs to be backported v1.3.0 v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nknize @opensearch-ci-bot @adnapibar