Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1x] Deprecate setting explicit version on analysis component (#1978) #1985

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Jan 27, 2022

Backport of #1978. Lucene 9 removes the ability to define an explicit version on an analysis component. The version parameter is deprecated at parse time and a warning is issued to the user through the deprecation logger.

…h-project#1978)

Lucene 9 removes the ability to define an explicit version on an analysis
component. The version parameter is deprecated at parse time and a warning is
issued to the user through the deprecation logger.

Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize nknize added backport PRs or issues specific to backporting features or enhancments deprecate v1.3.0 labels Jan 27, 2022
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 11c578b
Log 2082

Reports 2082

@dblock dblock merged commit 65f12d8 into opensearch-project:1.x Feb 2, 2022
@dblock
Copy link
Member

dblock commented Feb 2, 2022

I may have merged too fast. Did you mean for this parameter to not be used anymore in 1.x? Isn't that an incompatible change in behavior? @nknize

@nknize
Copy link
Collaborator Author

nknize commented Feb 2, 2022

The parameter is removed in 2.0 so this PR deprecates it in 1.x by issuing a deprecation warning. It doesn't mean it can't be used, it just shouldn't be used. BWC is supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments deprecate Severity-Blocker v1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants