Compare strings with equals() instead of == #16461

dk2k · 2024-10-23T18:12:20Z

Previous PR #16415

Signed-off-by: Dmitry Kryukov <[email protected]>

…rch-project#16111) * Add support for restoring from snapshot with search replicas Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * Fixed PR comments Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * Fixed the issues in gradle precommit Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * Fixed flaky tests Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * Fixed precommit failure Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * Fixed the codecoverage for RestoreService Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * Fixed precommit failure Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * removing unwanted tests Signed-off-by: Vinay Krishna Pudyodu <[email protected]> * Update CHANGELOG.md Co-authored-by: Marc Handalian <[email protected]> Signed-off-by: Vinay Krishna Pudyodu <[email protected]> --------- Signed-off-by: Vinay Krishna Pudyodu <[email protected]> Signed-off-by: Vinay Krishna Pudyodu <[email protected]> Co-authored-by: Vinay Krishna Pudyodu <[email protected]> Co-authored-by: Marc Handalian <[email protected]>

github-actions · 2024-10-23T19:19:31Z

❌ Gradle check result for 0fb573a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-10-24T04:31:13Z

❌ Gradle check result for 0fb573a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

… /plugins/repository-gcs (opensearch-project#16504) * Bump com.google.cloud:google-cloud-core-http in /plugins/repository-gcs Bumps com.google.cloud:google-cloud-core-http from 2.23.0 to 2.47.0. --- updated-dependencies: - dependency-name: com.google.cloud:google-cloud-core-http dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: gaobinlong <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: gaobinlong <[email protected]>

…earch-project#16581) * Support installing plugin SNAPSHOTs with SNASPHOT distribution Signed-off-by: Andriy Redko <[email protected]> * Use Build.CURRENT directly for snapshots Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]>

…#16533) * Update DEVELOPER_GUIDE.md instructions for JDK-11 Signed-off-by: Andriy Redko <[email protected]> * Address review comments Signed-off-by: Andriy Redko <[email protected]> * Update DEVELOPER_GUIDE.md Co-authored-by: Andrew Ross <[email protected]> Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: Andrew Ross <[email protected]>

…tion to run under a parent filter aggregation (opensearch-project#16652) Signed-off-by: Gao Binlong <[email protected]>

…ebuddy from 1.15.4 to 1.15.10 (opensearch-project#16655) * Bump mockito from 5.14.1 to 5.14.2 Signed-off-by: Craig Perkins <[email protected]> * Update objenesis from 3.2 to 3.3 Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Update bytebuddy from 1.15.4 to 1.15.10 Signed-off-by: Craig Perkins <[email protected]> * Update README Signed-off-by: Craig Perkins <[email protected]> * Add grant to mockito-core Signed-off-by: Craig Perkins <[email protected]> * Add perms Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>

Signed-off-by: Andriy Redko <[email protected]>

* search dv only ip masks Signed-off-by: mikhail-khludnev <[email protected]> * search dv only ip masks: changes Signed-off-by: Mikhail Khludnev <[email protected]> * drop fancy closures Signed-off-by: mikhail-khludnev <[email protected]> * drop fancy closures. one more Signed-off-by: mikhail-khludnev <[email protected]> * fix unit tests; add some more dvOnly Signed-off-by: mikhail-khludnev <[email protected]> * drop skipping dvOnly in 2.x Signed-off-by: mikhail-khludnev <[email protected]> * drop redundant brackets Signed-off-by: mikhail-khludnev <[email protected]> * extract conditions Signed-off-by: mikhail-khludnev <[email protected]> * asserts Signed-off-by: mikhail-khludnev <[email protected]> * spotless apply Signed-off-by: mikhail-khludnev <[email protected]> * bring back skip before Signed-off-by: mikhail-khludnev <[email protected]> * combine asserts Signed-off-by: mikhail-khludnev <[email protected]> * inline, copy-paste Signed-off-by: mikhail-khludnev <[email protected]> --------- Signed-off-by: mikhail-khludnev <[email protected]> Signed-off-by: Mikhail Khludnev <[email protected]> Co-authored-by: mikhail-khludnev <[email protected]>

…/fixtures/hdfs-fixture (opensearch-project#16665) * Bump org.xerial.snappy:snappy-java in /test/fixtures/hdfs-fixture Bumps [org.xerial.snappy:snappy-java](https://github.com/xerial/snappy-java) from 1.1.10.6 to 1.1.10.7. - [Release notes](https://github.com/xerial/snappy-java/releases) - [Commits](xerial/snappy-java@v1.1.10.6...v1.1.10.7) --- updated-dependencies: - dependency-name: org.xerial.snappy:snappy-java dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>

…16669) Bumps com.gradle.develocity from 3.18.1 to 3.18.2. --- updated-dependencies: - dependency-name: com.gradle.develocity dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Sooraj Sinha <[email protected]>

Signed-off-by: Andriy Redko <[email protected]>

…search-project#16685)

…project#16570) Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]>

* Bump codecov/codecov-action from 4 to 5 Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4 to 5. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4...v5) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>

…2.0.0 to v1-rev20241105-2.0.0 in /plugins/discovery-gce (opensearch-project#16613) * Bump com.google.apis:google-api-services-compute Bumps com.google.apis:google-api-services-compute from v1-rev20241021-2.0.0 to v1-rev20241105-2.0.0. --- updated-dependencies: - dependency-name: com.google.apis:google-api-services-compute dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>

linuxpi · 2024-11-20T05:57:29Z

CHANGELOG.md

@@ -97,6 +97,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Fix typo super->sb in method toString() of RemoteStoreNodeAttribute ([#15362](https://github.com/opensearch-project/OpenSearch/pull/15362))
 - [Workload Management] Fixing Create/Update QueryGroup TransportActions to execute from non-cluster manager nodes ([16422](https://github.com/opensearch-project/OpenSearch/pull/16422))
 - Fix flaky test in `testApproximateRangeWithSizeOverDefault` by adjusting totalHits assertion logic ([#16434](https://github.com/opensearch-project/OpenSearch/pull/16434#pullrequestreview-2386999409))
+- Fix string equality comparisons ([#16461](https://github.com/opensearch-project/OpenSearch/pull/16461))


we dont need changelog for such changes

Can we have it merged as is? I don't fancy creating one more PR after another unsuccessful rebase

There's already a conflict in CHANGELOG, gradle checks failed, and the diff looks big now :( Appreciate your help in rebasing this. I marked this PR skip-changelog so you can just revert that file.

…16682) * Separating remote download and publication stats Signed-off-by: Himshikha Gupta <[email protected]>

Signed-off-by: Andriy Redko <[email protected]>

…rds are closed (opensearch-project#16560) * added draft tests for tsc stats holder Signed-off-by: Peter Alfonsi <[email protected]> * first draft tsc stats bugfix Signed-off-by: Peter Alfonsi <[email protected]> * Complete tests Signed-off-by: Peter Alfonsi <[email protected]> * Cleanup Signed-off-by: Peter Alfonsi <[email protected]> * Integrate fix with TSC Signed-off-by: Peter Alfonsi <[email protected]> * Add IT Signed-off-by: Peter Alfonsi <[email protected]> * Refactor cache package names in TSC module to match with server Signed-off-by: Peter Alfonsi <[email protected]> * changelog Signed-off-by: Peter Alfonsi <[email protected]> * Revert "Refactor cache package names in TSC module to match with server" This reverts commit 3b15a7a. Signed-off-by: Peter Alfonsi <[email protected]> * Addressed Sagar's comments Signed-off-by: Peter Alfonsi <[email protected]> * More package fixes Signed-off-by: Peter Alfonsi <[email protected]> * Addressed andross's comments Signed-off-by: Peter Alfonsi <[email protected]> --------- Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]>

Signed-off-by: Dmitry Kryukov <[email protected]>

…ng_comparison_fix # Conflicts: # CHANGELOG.md

dk2k · 2024-11-23T14:34:56Z

Rebase failed again. It sucks!

Previous PR opensearch-project#16461 Signed-off-by: Dmitry Kryukov <[email protected]>

dk2k · 2024-11-23T14:39:32Z

New PR #16714

github-actions · 2024-11-23T15:27:49Z

❌ Gradle check result for aafa636: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Compare strings with equals() instead of ==

e3159a9

Signed-off-by: Dmitry Kryukov <[email protected]>

Updated CHANGELOG.md

0fb573a

Signed-off-by: Dmitry Kryukov <[email protected]>

dk2k mentioned this pull request Oct 23, 2024

Compare strings with equals() instead of == #16415

Closed

opensearch-ci-bot mentioned this pull request Oct 24, 2024

[AUTOCUT] Gradle Check Flaky Test Report for SpecificClusterManagerNodesIT #15944

Open

dependabot bot and others added 15 commits November 14, 2024 15:40

Update version check in yaml test file for allowing composite aggrega…

efef676

…tion to run under a parent filter aggregation (opensearch-project#16652) Signed-off-by: Gao Binlong <[email protected]>

Update to Netty 4.1.115.Final (opensearch-project#16661)

8e097ee

Signed-off-by: Andriy Redko <[email protected]>

Fix stale cluster state custom file deletion (opensearch-project#16670)

ac44300

Signed-off-by: Sooraj Sinha <[email protected]>

Update Gradle to 8.11 (opensearch-project#16386)

9b8b9fd

Signed-off-by: Andriy Redko <[email protected]>

Update Gradle version for Detect Breaking Changes Github action (open…

1d8568e

…search-project#16685)

Changing request cache size > 0 setting to int threshold (opensearch-…

2ac64a6

…project#16570) Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]>

linuxpi reviewed Nov 20, 2024

View reviewed changes

Separating remote download and publication stats (opensearch-project#…

b1a7743

…16682) * Separating remote download and publication stats Signed-off-by: Himshikha Gupta <[email protected]>

dblock added the skip-changelog label Nov 22, 2024

reta and others added 4 commits November 22, 2024 10:12

Update Gradle to 8.11.1 (opensearch-project#16694)

9388217

Signed-off-by: Andriy Redko <[email protected]>

Compare strings with equals() instead of ==

714381b

Signed-off-by: Dmitry Kryukov <[email protected]>

Merge remote-tracking branch 'origin/string_comparison_fix' into stri…

aafa636

…ng_comparison_fix # Conflicts: # CHANGELOG.md

dk2k requested a review from peternied as a code owner November 23, 2024 14:34

dk2k closed this Nov 23, 2024

dk2k added a commit to dk2k/OpenSearch that referenced this pull request Nov 23, 2024

Use equalsTo() for string comparison instead of ==

17e4cf9

Previous PR opensearch-project#16461 Signed-off-by: Dmitry Kryukov <[email protected]>

dk2k mentioned this pull request Nov 23, 2024

Use equalsTo() for string comparison instead of == #16714

Open

opensearch-ci-bot mentioned this pull request Nov 23, 2024

[AUTOCUT] Gradle Check Flaky Test Report for RemoteStorePinnedTimestampsGarbageCollectionIT #16088

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compare strings with equals() instead of == #16461

Compare strings with equals() instead of == #16461

dk2k commented Oct 23, 2024

github-actions bot commented Oct 23, 2024

github-actions bot commented Oct 24, 2024

linuxpi Nov 20, 2024

dk2k Nov 20, 2024

dblock Nov 22, 2024 •

edited

Loading

dk2k commented Nov 23, 2024

dk2k commented Nov 23, 2024

github-actions bot commented Nov 23, 2024

Compare strings with equals() instead of == #16461

Compare strings with equals() instead of == #16461

Conversation

dk2k commented Oct 23, 2024

github-actions bot commented Oct 23, 2024

github-actions bot commented Oct 24, 2024

linuxpi Nov 20, 2024

Choose a reason for hiding this comment

dk2k Nov 20, 2024

Choose a reason for hiding this comment

dblock Nov 22, 2024 • edited Loading

Choose a reason for hiding this comment

dk2k commented Nov 23, 2024

dk2k commented Nov 23, 2024

github-actions bot commented Nov 23, 2024

dblock Nov 22, 2024 •

edited

Loading