Compare strings with equals() instead of == #16415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Kryukov <[email protected]>
dk2k
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
jainankitk and
linuxpi
as code owners
Signed-off-by: Dmitry Kryukov <[email protected]>
|
❌ Gradle check result for d138929: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
dbwiddis
reviewed
Oct 21, 2024
server/src/main/java/org/opensearch/search/suggest/phrase/NoisyChannelSpellChecker.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/opensearch/index/shard/IndexShardTestCase.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Dmitry Kryukov <[email protected]>
|
❌ Gradle check result for 28de794: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
dbwiddis
approved these changes
Oct 23, 2024
|
DCO is failing because the email extension in your "Author" information doesn't match the email extension in your signoff. Can you correct that please? |
|
Will continue here #16461 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR #15369
(rebase caused mess again)