Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete keyword changes for star tree #16233

Merged
merged 17 commits into from
Nov 12, 2024

Merge branch 'main' into keyword-iterator

5c4a0e5
Select commit
Loading
Failed to load commit list.
Merged

Complete keyword changes for star tree #16233

Merge branch 'main' into keyword-iterator
5c4a0e5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 12, 2024 in 1s

72.08% (target 70.00%)

View this Pull Request on Codecov

72.08% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 83.83459% with 43 lines in your changes missing coverage. Please review.

Project coverage is 72.08%. Comparing base (10873f1) to head (5c4a0e5).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...be/startree/utils/SequentialDocValuesIterator.java 52.94% 3 Missing and 5 partials ⚠️
...ndex/compositeindex/datacube/DimensionFactory.java 33.33% 4 Missing and 2 partials ⚠️
...be/startree/fileformats/meta/StarTreeMetadata.java 57.14% 5 Missing and 1 partial ⚠️
...rtree/fileformats/meta/StarTreeMetadataWriter.java 45.45% 5 Missing and 1 partial ⚠️
...ndex/compositeindex/datacube/KeywordDimension.java 73.68% 5 Missing ⚠️
...datacube/startree/builder/BaseStarTreeBuilder.java 94.73% 2 Missing and 3 partials ⚠️
...eindex/datacube/startree/index/StarTreeValues.java 81.25% 0 Missing and 3 partials ⚠️
...tils/iterator/SortedSetStarTreeValuesIterator.java 66.66% 3 Missing ⚠️
...site/composite912/Composite912DocValuesWriter.java 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #16233      +/-   ##
============================================
- Coverage     72.15%   72.08%   -0.07%     
- Complexity    65145    65175      +30     
============================================
  Files          5315     5318       +3     
  Lines        303573   303781     +208     
  Branches      43925    43951      +26     
============================================
- Hits         219039   218991      -48     
- Misses        66587    66854     +267     
+ Partials      17947    17936      -11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov