-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete keyword changes for star tree #16233
Complete keyword changes for star tree #16233
Conversation
Signed-off-by: Bharathwaj G <[email protected]>
❌ Gradle check result for bbb9ed0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
bbb9ed0
to
57b0517
Compare
❌ Gradle check result for 57b0517: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Bharathwaj G <[email protected]>
57b0517
to
a48de57
Compare
❌ Gradle check result for a48de57: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Bharathwaj G <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16233 +/- ##
============================================
- Coverage 72.15% 72.08% -0.07%
- Complexity 65145 65175 +30
============================================
Files 5315 5318 +3
Lines 303573 303781 +208
Branches 43925 43951 +26
============================================
- Hits 219039 218991 -48
- Misses 66587 66854 +267
+ Partials 17947 17936 -11 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
...main/java/org/opensearch/index/codec/composite/composite912/Composite912DocValuesWriter.java
Show resolved
Hide resolved
.../java/org/opensearch/index/compositeindex/datacube/startree/builder/BaseStarTreeBuilder.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/index/compositeindex/datacube/startree/builder/BaseStarTreeBuilder.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/index/compositeindex/datacube/startree/builder/BaseStarTreeBuilder.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/index/compositeindex/datacube/startree/builder/BaseStarTreeBuilder.java
Show resolved
Hide resolved
.../java/org/opensearch/index/compositeindex/datacube/startree/builder/BaseStarTreeBuilder.java
Show resolved
Hide resolved
.../java/org/opensearch/index/compositeindex/datacube/startree/builder/BaseStarTreeBuilder.java
Show resolved
Hide resolved
...ain/java/org/opensearch/index/compositeindex/datacube/startree/builder/StarTreesBuilder.java
Outdated
Show resolved
Hide resolved
...ensearch/index/compositeindex/datacube/startree/fileformats/meta/StarTreeMetadataWriter.java
Show resolved
Hide resolved
Signed-off-by: Bharathwaj G <[email protected]>
a2257ee
to
e37485a
Compare
❌ Gradle check result for e37485a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
e37485a
to
6688d4b
Compare
❌ Gradle check result for 6688d4b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 0af594b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 0af594b: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Bharathwaj G <[email protected]>
❕ Gradle check result for 5c4a0e5: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16233-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7f27ddca1c3dc9f4ff6fa4216c7f28171cec3db9
# Push it to GitHub
git push --set-upstream origin backport/backport-16233-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16233-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7f27ddca1c3dc9f4ff6fa4216c7f28171cec3db9
# Push it to GitHub
git push --set-upstream origin backport/backport-16233-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
Description
This PR adds support for keyword fields with changes end to end that includes flush, merge and file format changes.
As part of "ordered_dimensions" as part of star tree mapping , users can provide keyword fields as well now. [ Metrics are not supported for keyword, its still "numeric-only" supported for star tree]
Related Issues
Resolves #16232
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.