Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete keyword changes for star tree #16233

Merged
merged 17 commits into from
Nov 12, 2024

Conversation

bharath-techie
Copy link
Contributor

@bharath-techie bharath-techie commented Oct 8, 2024

Description

This PR adds support for keyword fields with changes end to end that includes flush, merge and file format changes.

As part of "ordered_dimensions" as part of star tree mapping , users can provide keyword fields as well now. [ Metrics are not supported for keyword, its still "numeric-only" supported for star tree]

Related Issues

Resolves #16232

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Bharathwaj G <[email protected]>
Copy link
Contributor

github-actions bot commented Oct 8, 2024

❌ Gradle check result for bbb9ed0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 8, 2024

❌ Gradle check result for 57b0517: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for a48de57: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Bharathwaj G <[email protected]>
Copy link
Contributor

✅ Gradle check result for 9238f17: SUCCESS

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 83.83459% with 43 lines in your changes missing coverage. Please review.

Project coverage is 72.08%. Comparing base (10873f1) to head (5c4a0e5).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
...be/startree/utils/SequentialDocValuesIterator.java 52.94% 3 Missing and 5 partials ⚠️
...ndex/compositeindex/datacube/DimensionFactory.java 33.33% 4 Missing and 2 partials ⚠️
...be/startree/fileformats/meta/StarTreeMetadata.java 57.14% 5 Missing and 1 partial ⚠️
...rtree/fileformats/meta/StarTreeMetadataWriter.java 45.45% 5 Missing and 1 partial ⚠️
...ndex/compositeindex/datacube/KeywordDimension.java 73.68% 5 Missing ⚠️
...datacube/startree/builder/BaseStarTreeBuilder.java 94.73% 2 Missing and 3 partials ⚠️
...eindex/datacube/startree/index/StarTreeValues.java 81.25% 0 Missing and 3 partials ⚠️
...tils/iterator/SortedSetStarTreeValuesIterator.java 66.66% 3 Missing ⚠️
...site/composite912/Composite912DocValuesWriter.java 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16233      +/-   ##
============================================
- Coverage     72.15%   72.08%   -0.07%     
- Complexity    65145    65175      +30     
============================================
  Files          5315     5318       +3     
  Lines        303573   303781     +208     
  Branches      43925    43951      +26     
============================================
- Hits         219039   218991      -48     
- Misses        66587    66854     +267     
+ Partials      17947    17936      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Signed-off-by: Bharathwaj G <[email protected]>
Copy link
Contributor

❌ Gradle check result for e37485a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 6688d4b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 0af594b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 0af594b: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

❕ Gradle check result for 5c4a0e5: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@sachinpkale sachinpkale merged commit 7f27ddc into opensearch-project:main Nov 12, 2024
37 of 38 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Nov 12, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16233-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7f27ddca1c3dc9f4ff6fa4216c7f28171cec3db9
# Push it to GitHub
git push --set-upstream origin backport/backport-16233-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-16233-to-2.x.

@bharath-techie bharath-techie added backport 2.x Backport to 2.x branch and removed backport-failed backport 2.x Backport to 2.x branch labels Nov 13, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16233-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7f27ddca1c3dc9f4ff6fa4216c7f28171cec3db9
# Push it to GitHub
git push --set-upstream origin backport/backport-16233-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-16233-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed enhancement Enhancement or improvement to existing feature or request Indexing:Performance skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support for keyword fields as part of star tree index mapping
4 participants