Add matchesPluginSystemIndexPattern to SystemIndexRegistry

[cwperks]

Description

Adds a method called matchesPluginSystemIndexPattern to SystemIndexRegistry which was added in a recent PR.

This PR relates to another open PR which introduces a new mechanism for plugins to switch context outside of an authenticated user context.

This new method takes a plugin's canonical class name and set of index expressions in as params to determine if the request matches system indices registered to that particular plugin.

This PR also changes the method signature to accept a Set which fits the security use-case better and avoids having to convert between array and set.

Related Issues

Related to #14733

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

✅ Gradle check result for 9e20ebc: SUCCESS

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.69%. Comparing base (6b8b3ef) to head (609b715).
Report is 5 commits behind head on main.

Files	Patch %	Lines
...va/org/opensearch/indices/SystemIndexRegistry.java	85.71%	1 Missing and 1 partial ⚠️
server/src/main/java/org/opensearch/node/Node.java	33.33%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #14750      +/-   ##
============================================
- Coverage     71.82%   71.69%   -0.13%     
+ Complexity    62467    62409      -58     
============================================
  Files          5149     5149              
  Lines        293396   293402       +6     
  Branches      42392    42392              
============================================
- Hits         210725   210356     -369     
- Misses        65245    65674     +429     
+ Partials      17426    17372      -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

✅ Gradle check result for 6438734: SUCCESS

[github-actions]

❌ Gradle check result for 541b8bd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[cwperks]

Test Result (1 failure / +1)
org.opensearch.index.remote.RemoteSegmentTransferTrackerTests.testComputeTimeLagOnUpdate

[github-actions]

❌ Gradle check result for 8c3d0b5: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 7992ed2: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 8c3d0b5: SUCCESS

[github-actions]

✅ Gradle check result for 609b715: SUCCESS

[cwperks]

@reta How can we resolve the issue to publish Snapshots to maven. Looks like the workflow failed after this merge:

ref: https://github.com/opensearch-project/OpenSearch/actions/runs/9956623466/job/27506933996

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':rest-api-spec:publishNebulaPublicationToSnapshotsRepository'.
> Failed to publish publication 'nebula' to repository 'Snapshots'
   > Could not PUT 'https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/rest-api-spec/3.0.0-SNAPSHOT/rest-api-spec-3.0.0-20240716.121646-2590.jar'. Received status code 401 from server: Content access is protected by token

[reta]

@reta How can we resolve the issue to publish Snapshots to maven. Looks like the workflow failed after this merge:

@cwperks restated the workflow, it happens from time to time sadly, but I don't know why (this is 100% AWS managed infra)