Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add matchesPluginSystemIndexPattern to SystemIndexRegistry #14770

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 6ad57bf from #14750.

* Add matchesPluginSystemIndexPattern to SystemIndexRegistry

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Use single data structure to keep track of system indices

Signed-off-by: Craig Perkins <[email protected]>

* Address code review comments

Signed-off-by: Craig Perkins <[email protected]>

* Add test for getAllDescriptors

Signed-off-by: Craig Perkins <[email protected]>

* Update server/src/main/java/org/opensearch/indices/SystemIndexRegistry.java

Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
(cherry picked from commit 6ad57bf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

✅ Gradle check result for 3313146: SUCCESS

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.54%. Comparing base (697396b) to head (3313146).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...va/org/opensearch/indices/SystemIndexRegistry.java 85.71% 1 Missing and 1 partial ⚠️
server/src/main/java/org/opensearch/node/Node.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #14770      +/-   ##
============================================
- Coverage     71.61%   71.54%   -0.07%     
+ Complexity    62504    62473      -31     
============================================
  Files          5106     5106              
  Lines        293554   293560       +6     
  Branches      42772    42772              
============================================
- Hits         210228   210037     -191     
- Misses        65688    65924     +236     
+ Partials      17638    17599      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 2f213fb into 2.x Jul 16, 2024
52 checks passed
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…h-project#14750) (opensearch-project#14770)

* Add matchesPluginSystemIndexPattern to SystemIndexRegistry

* Add to CHANGELOG

* Use single data structure to keep track of system indices

* Address code review comments

* Add test for getAllDescriptors

* Update server/src/main/java/org/opensearch/indices/SystemIndexRegistry.java

---------

(cherry picked from commit 6ad57bf)

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andriy Redko <[email protected]>
Signed-off-by: kkewwei <[email protected]>
@dbwiddis dbwiddis deleted the backport/backport-14750-to-2.x branch July 24, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant