Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Streaming Indexing] Enhance RestClient with a new streaming API support #14437

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Jun 18, 2024

Description

Enhance RestClient with a new streaming API support

Related Issues

Resolves #9072

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request v2.16.0 Issues and PRs related to version 2.16.0 v3.0.0 Issues and PRs related to version 3.0.0 labels Jun 18, 2024
Copy link
Contributor

❌ Gradle check result for a6ec079: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta added backport 2.x Backport to 2.x branch and removed skip-changelog labels Jun 18, 2024
Copy link
Contributor

❌ Gradle check result for 5b112c6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 4afb721: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 4afb721: SUCCESS

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 28.08511% with 169 lines in your changes missing coverage. Please review.

Project coverage is 71.83%. Comparing base (eb306d2) to head (ae79354).
Report is 2 commits behind head on main.

Files Patch % Lines
...rc/main/java/org/opensearch/client/RestClient.java 23.00% 87 Missing ⚠️
.../rest/action/document/RestBulkStreamingAction.java 0.00% 23 Missing ⚠️
.../java/org/opensearch/client/StreamingResponse.java 0.00% 17 Missing ⚠️
...ch/client/http/ReactiveHttpUriRequestProducer.java 0.00% 16 Missing ⚠️
...n/java/org/opensearch/client/StreamingRequest.java 43.47% 12 Missing and 1 partial ⚠️
...c/main/java/org/opensearch/client/Cancellable.java 0.00% 7 Missing ⚠️
...r/netty4/ReactorNetty4NonStreamingHttpChannel.java 57.14% 3 Missing ⚠️
...g/opensearch/client/ResponseWarningsExtractor.java 94.73% 0 Missing and 1 partial ⚠️
...ctor/netty4/ReactorNetty4StreamingHttpChannel.java 50.00% 1 Missing ⚠️
.../main/java/org/opensearch/rest/RestController.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14437      +/-   ##
============================================
+ Coverage     71.77%   71.83%   +0.05%     
- Complexity    62689    62811     +122     
============================================
  Files          5163     5167       +4     
  Lines        294412   294610     +198     
  Branches      42582    42602      +20     
============================================
+ Hits         211325   211621     +296     
+ Misses        65689    65581     -108     
- Partials      17398    17408      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

✅ Gradle check result for 5727a15: SUCCESS

Copy link
Contributor

✅ Gradle check result for 2013db6: SUCCESS

Copy link
Contributor

❕ Gradle check result for 6150ca1: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

❌ Gradle check result for 07b0ec0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for caadea4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for d261cd6: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@reta
Copy link
Collaborator Author

reta commented Jul 30, 2024

@reta Sorry for the delay on the review and now we've got a conflict :(

Thanks a lot @andrross , resolved!

Copy link
Contributor

✅ Gradle check result for 0fc506a: SUCCESS

Copy link
Contributor

✅ Gradle check result for ae79354: SUCCESS

@reta
Copy link
Collaborator Author

reta commented Jul 31, 2024

@andrross if you don't mind please, one more time to approve (conflicts again!), thank you!

@andrross andrross merged commit 79f45be into opensearch-project:main Jul 31, 2024
29 of 31 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-14437-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 79f45be4a544dd3519521294b63bd1630c3dfd54
# Push it to GitHub
git push --set-upstream origin backport/backport-14437-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-14437-to-2.x.

reta added a commit to reta/OpenSearch that referenced this pull request Aug 2, 2024
…ort (opensearch-project#14437)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 79f45be)
Signed-off-by: Andriy Redko <[email protected]>
reta added a commit to reta/OpenSearch that referenced this pull request Aug 2, 2024
…ort (opensearch-project#14437)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 79f45be)
Signed-off-by: Andriy Redko <[email protected]>
reta added a commit to reta/OpenSearch that referenced this pull request Aug 6, 2024
…ort (opensearch-project#14437)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 79f45be)
Signed-off-by: Andriy Redko <[email protected]>
reta added a commit to reta/OpenSearch that referenced this pull request Aug 6, 2024
…ort (opensearch-project#14437)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 79f45be)
Signed-off-by: Andriy Redko <[email protected]>
reta added a commit to reta/OpenSearch that referenced this pull request Aug 6, 2024
…ort (opensearch-project#14437)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 79f45be)
Signed-off-by: Andriy Redko <[email protected]>
reta added a commit to reta/OpenSearch that referenced this pull request Aug 8, 2024
…ort (opensearch-project#14437)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 79f45be)
Signed-off-by: Andriy Redko <[email protected]>
reta added a commit that referenced this pull request Aug 8, 2024
…ort (#14437) (#15089)

(cherry picked from commit 79f45be)

Signed-off-by: Andriy Redko <[email protected]>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Aug 20, 2024
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request v2.17.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Streaming Indexing] Enhance RestClient with a new streaming API support
2 participants