-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Streaming Indexing] Enhance RestClient with a new streaming API support #14437
Conversation
❌ Gradle check result for a6ec079: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 5b112c6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 4afb721: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14437 +/- ##
============================================
+ Coverage 71.77% 71.83% +0.05%
- Complexity 62689 62811 +122
============================================
Files 5163 5167 +4
Lines 294412 294610 +198
Branches 42582 42602 +20
============================================
+ Hits 211325 211621 +296
+ Misses 65689 65581 -108
- Partials 17398 17408 +10 ☔ View full report in Codecov by Sentry. |
❕ Gradle check result for 6150ca1: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
❌ Gradle check result for 07b0ec0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for caadea4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for d261cd6: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Andriy Redko <[email protected]>
@andrross if you don't mind please, one more time to approve (conflicts again!), thank you! |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-14437-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 79f45be4a544dd3519521294b63bd1630c3dfd54
# Push it to GitHub
git push --set-upstream origin backport/backport-14437-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…ort (opensearch-project#14437) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 79f45be) Signed-off-by: Andriy Redko <[email protected]>
…ort (opensearch-project#14437) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 79f45be) Signed-off-by: Andriy Redko <[email protected]>
…ort (opensearch-project#14437) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 79f45be) Signed-off-by: Andriy Redko <[email protected]>
…ort (opensearch-project#14437) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 79f45be) Signed-off-by: Andriy Redko <[email protected]>
…ort (opensearch-project#14437) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 79f45be) Signed-off-by: Andriy Redko <[email protected]>
…ort (opensearch-project#14437) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 79f45be) Signed-off-by: Andriy Redko <[email protected]>
…ort (#14437) (#15089) (cherry picked from commit 79f45be) Signed-off-by: Andriy Redko <[email protected]>
…ort (opensearch-project#14437) Signed-off-by: Andriy Redko <[email protected]>
…ort (opensearch-project#14437) Signed-off-by: Andriy Redko <[email protected]>
Description
Enhance
RestClient
with a new streaming API supportRelated Issues
Resolves #9072
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.