Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [2.x] [Streaming Indexing] Enhance RestClient with a new streaming API support (#14437) #15089

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Aug 2, 2024

Backport of #14437 to 2.x

Copy link
Contributor

github-actions bot commented Aug 2, 2024

❌ Gradle check result for 2b1ea3e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the backport/backport-14437-to-2.x branch from 2b1ea3e to b4034b9 Compare August 2, 2024 18:08
Copy link
Contributor

github-actions bot commented Aug 2, 2024

❌ Gradle check result for b4034b9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Aug 5, 2024

❌ Gradle check result for b4034b9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the backport/backport-14437-to-2.x branch from b4034b9 to d7a5e20 Compare August 6, 2024 15:43
Copy link
Contributor

github-actions bot commented Aug 6, 2024

❌ Gradle check result for d7a5e20: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta reta force-pushed the backport/backport-14437-to-2.x branch 2 times, most recently from c4d9324 to a5323d3 Compare August 6, 2024 18:28
Copy link
Contributor

github-actions bot commented Aug 6, 2024

❌ Gradle check result for c4d9324: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Aug 6, 2024

❌ Gradle check result for a5323d3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…ort (opensearch-project#14437)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 79f45be)
Signed-off-by: Andriy Redko <[email protected]>
@reta reta force-pushed the backport/backport-14437-to-2.x branch from a5323d3 to 191daa0 Compare August 8, 2024 00:19
Copy link
Contributor

github-actions bot commented Aug 8, 2024

✅ Gradle check result for 191daa0: SUCCESS

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 18.99038% with 337 lines in your changes missing coverage. Please review.

Project coverage is 71.39%. Comparing base (e5e1bad) to head (191daa0).
Report is 32 commits behind head on 2.x.

Files Patch % Lines
...rc/main/java/org/opensearch/client/RestClient.java 31.70% 83 Missing and 1 partial ⚠️
...va/org/opensearch/client/ReactiveDataProducer.java 0.00% 63 Missing ⚠️
...va/org/opensearch/client/ReactiveDataConsumer.java 0.00% 53 Missing ⚠️
...org/opensearch/client/ReactiveRequestProducer.java 0.00% 49 Missing ⚠️
.../rest/action/document/RestBulkStreamingAction.java 0.00% 23 Missing ⚠️
.../java/org/opensearch/client/StreamingResponse.java 0.00% 17 Missing ⚠️
...rg/opensearch/client/ReactiveResponseConsumer.java 0.00% 15 Missing ⚠️
...n/java/org/opensearch/client/StreamingRequest.java 43.47% 12 Missing and 1 partial ⚠️
...c/main/java/org/opensearch/client/Cancellable.java 0.00% 7 Missing ⚠️
...t/src/main/java/org/opensearch/client/Message.java 0.00% 7 Missing ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15089      +/-   ##
============================================
- Coverage     71.48%   71.39%   -0.10%     
- Complexity    62677    62705      +28     
============================================
  Files          5123     5135      +12     
  Lines        294480   295009     +529     
  Branches      42912    42972      +60     
============================================
+ Hits         210518   210618     +100     
- Misses        66286    66714     +428     
- Partials      17676    17677       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta
Copy link
Collaborator Author

reta commented Aug 8, 2024

@andrross this is a backport for streaming Rest Client for 2.x: the large difference is that 2.x is still uses Apache HttpClient 4.x, more things needed to be implemented there (hence the difference in files), thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants