Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flat object field use IndexOrDocValuesQuery to optimize query #14383

Merged

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Jun 16, 2024

Description

The pr mainly support the two features:
1.flat object field use IndexOrDocValuesQuery to optimize query.
2.flat object field delegate to keyword field to reduce code duplication.

Related Issues

Resolves #11635 #11537

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 9da1d18: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei
Copy link
Contributor Author

kkewwei commented Jun 17, 2024

After #13853 is merged, the pr can be merged later.

Copy link
Contributor

❌ Gradle check result for 48b7f47: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@harshavamsi
Copy link
Contributor

@kkewwei looks like a bunch of flat_object tests are failing. I can review once we have green gradle!

Copy link
Contributor

❌ Gradle check result for b3dd31b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the support_flat_object_docvalue branch from b3dd31b to 6b21e8b Compare September 30, 2024 03:10
Copy link
Contributor

❌ Gradle check result for 6b21e8b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei
Copy link
Contributor Author

kkewwei commented Sep 30, 2024

❌ Gradle check result for 6b21e8b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

SpecificClusterManagerNodesIT.testElectOnlyBetweenClusterManagerNodes #16015

Copy link
Contributor

github-actions bot commented Oct 5, 2024

✅ Gradle check result for bd77d36: SUCCESS

Copy link
Contributor

github-actions bot commented Oct 7, 2024

✅ Gradle check result for 1be6b1e: SUCCESS

Copy link
Collaborator

@msfroh msfroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this is looking pretty good to me. Thanks @kkewwei!

I posted one question about the behavior of fuzzy query (though I guess it could apply to some of the other queries? Or maybe not. I think prefix, regexp, wildcard, and range queries all force the dot-path to match exactly.) I don't think it's a blocker, but I'm mostly curious to know if we can get possibly surprising behavior.

Copy link
Contributor

❌ Gradle check result for 74086ae: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for b9366dc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the support_flat_object_docvalue branch from b9366dc to cdcb03a Compare October 14, 2024 12:50
Copy link
Contributor

✅ Gradle check result for cdcb03a: SUCCESS

@msfroh msfroh merged commit 9ddee61 into opensearch-project:main Oct 14, 2024
39 of 40 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-14383-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9ddee61b1b4eafebe9b4d30e997b40178c939a5e
# Push it to GitHub
git push --set-upstream origin backport/backport-14383-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-14383-to-2.x.

@msfroh
Copy link
Collaborator

msfroh commented Oct 14, 2024

Darn... auto-backport failed. Probably just a conflict on the changelog.

@kkewwei, could you please open a manual backport PR?

kkewwei added a commit to kkewwei/OpenSearch that referenced this pull request Oct 15, 2024
@kkewwei kkewwei deleted the support_flat_object_docvalue branch October 16, 2024 00:29
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
msfroh added a commit to msfroh/OpenSearch that referenced this pull request Oct 28, 2024
… for most query types (opensearch-project#14383)"

This reverts commit 9ddee61.

Trying to identify the source of a benchmark regression for big5
keyword-in-range query.

Signed-off-by: Michael Froh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed bug Something isn't working Search:Query Capabilities v2.16.0 Issues and PRs related to version 2.16.0 v2.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Flat object field should delegate to keyword field for most query types
4 participants