-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flat object field use IndexOrDocValuesQuery to optimize query #14383
Flat object field use IndexOrDocValuesQuery to optimize query #14383
Conversation
server/src/test/java/org/opensearch/index/mapper/FlatObjectFieldTypeTests.java
Show resolved
Hide resolved
❌ Gradle check result for 9da1d18: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
9da1d18
to
48b7f47
Compare
After #13853 is merged, the pr can be merged later. |
❌ Gradle check result for 48b7f47: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@kkewwei looks like a bunch of |
❌ Gradle check result for b3dd31b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
b3dd31b
to
6b21e8b
Compare
❌ Gradle check result for 6b21e8b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
SpecificClusterManagerNodesIT.testElectOnlyBetweenClusterManagerNodes #16015 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this is looking pretty good to me. Thanks @kkewwei!
I posted one question about the behavior of fuzzy query (though I guess it could apply to some of the other queries? Or maybe not. I think prefix, regexp, wildcard, and range queries all force the dot-path to match exactly.) I don't think it's a blocker, but I'm mostly curious to know if we can get possibly surprising behavior.
rest-api-spec/src/main/resources/rest-api-spec/test/index/92_flat_object_support_doc_values.yml
Show resolved
Hide resolved
❌ Gradle check result for 74086ae: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
74086ae
to
b9366dc
Compare
❌ Gradle check result for b9366dc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: kkewwei <[email protected]>
b9366dc
to
cdcb03a
Compare
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-14383-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9ddee61b1b4eafebe9b4d30e997b40178c939a5e
# Push it to GitHub
git push --set-upstream origin backport/backport-14383-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
Darn... auto-backport failed. Probably just a conflict on the changelog. @kkewwei, could you please open a manual backport PR? |
…es (opensearch-project#14383) Signed-off-by: kkewwei <[email protected]>
…es (opensearch-project#14383) Signed-off-by: kkewwei <[email protected]>
…es (opensearch-project#14383) Signed-off-by: kkewwei <[email protected]>
…es (opensearch-project#14383) Signed-off-by: kkewwei <[email protected]>
… for most query types (opensearch-project#14383)" This reverts commit 9ddee61. Trying to identify the source of a benchmark regression for big5 keyword-in-range query. Signed-off-by: Michael Froh <[email protected]>
Description
The pr mainly support the two features:
1.flat object field use IndexOrDocValuesQuery to optimize query.
2.flat object field delegate to keyword field to reduce code duplication.
Related Issues
Resolves #11635 #11537
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.