Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Flat object field should delegate to keyword field for most query types #16326

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Oct 15, 2024

Description

Backport 9ddee61 from #14383

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 4acf291: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 4acf291: SUCCESS

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 79.31034% with 18 lines in your changes missing coverage. Please review.

Project coverage is 71.73%. Comparing base (5947002) to head (4acf291).
Report is 17 commits behind head on 2.x.

Files with missing lines Patch % Lines
...opensearch/index/mapper/FlatObjectFieldMapper.java 78.68% 4 Missing and 9 partials ⚠️
...rg/opensearch/index/mapper/KeywordFieldMapper.java 80.76% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16326      +/-   ##
============================================
- Coverage     71.74%   71.73%   -0.01%     
- Complexity    65022    65029       +7     
============================================
  Files          5302     5303       +1     
  Lines        303866   303843      -23     
  Branches      44192    44183       -9     
============================================
- Hits         218012   217970      -42     
- Misses        67648    67699      +51     
+ Partials      18206    18174      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kkewwei
Copy link
Contributor Author

kkewwei commented Oct 15, 2024

@msfroh, please have a look when you are free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants