-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix incorrect document order when there's exception during batch ingest #14341
Conversation
Signed-off-by: Liyun Xiu <[email protected]>
❌ Gradle check result for f54f43a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
open flaky issue #10785 |
Signed-off-by: Liyun Xiu <[email protected]>
❌ Gradle check result for 02dde2a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Tests with failures:
|
Signed-off-by: Liyun Xiu <[email protected]>
❕ Gradle check result for 5ed3400: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14341 +/- ##
============================================
+ Coverage 71.42% 71.73% +0.31%
- Complexity 59978 62086 +2108
============================================
Files 4985 5117 +132
Lines 282275 291712 +9437
Branches 40946 42168 +1222
============================================
+ Hits 201603 209253 +7650
- Misses 63999 65193 +1194
- Partials 16673 17266 +593 ☔ View full report in Codecov by Sentry. |
server/src/internalClusterTest/java/org/opensearch/ingest/IngestClientIT.java
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/ingest/IngestClientIT.java
Show resolved
Hide resolved
@chishui Can you send out a PR to address my comments about the tests? |
…atch ingest (#14341) Signed-off-by: Liyun Xiu <[email protected]> (cherry picked from commit d480027) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…atch ingest (#14341) Signed-off-by: Liyun Xiu <[email protected]> (cherry picked from commit d480027) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
will do |
…atch ingest (#14341) (#14359) (cherry picked from commit d480027) Signed-off-by: Liyun Xiu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…atch ingest (#14341) (#14358) (cherry picked from commit d480027) Signed-off-by: Liyun Xiu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…atch ingest (opensearch-project#14341) Signed-off-by: Liyun Xiu <[email protected]>
…atch ingest (opensearch-project#14341) (opensearch-project#14358) (cherry picked from commit d480027) Signed-off-by: Liyun Xiu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <[email protected]>
…atch ingest (opensearch-project#14341) Signed-off-by: Liyun Xiu <[email protected]>
Description
This is to fix a document incorrect order bug with batch ingestion when some docs run into exception.
bug is described here: #14336
the integration test here #14335 was also added.
Skip changelog and backport to 2.x
Related Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.