Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing tests for apparent batch reordering bug #14335

Conversation

andrross
Copy link
Member

@andrross andrross commented Jun 13, 2024

#14336

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 6595f8d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross andrross force-pushed the batch-ingest-reorder-failures branch from 6595f8d to 6cc0ea1 Compare June 13, 2024 23:22
Copy link
Contributor

❌ Gradle check result for 6cc0ea1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@chishui
Copy link
Contributor

chishui commented Jun 14, 2024

@andrross, to ensure the bug fix is covered by this test, I added it in the fix PR #14341, please take a look, thanks for adding the test and finding the bug.

@andrross
Copy link
Member Author

Closing as a PR with a fix has already been published.

@andrross andrross closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants