Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of special WrappingSearchAsyncActionPhase so the onPhaseStart() will always be followed by onPhaseEnd() within AbstractSearchAsyncAction #12293

Merged
merged 3 commits into from
Feb 16, 2024

Address code review comments

636440a
Select commit
Loading
Failed to load commit list.
Merged
Codecov / codecov/project succeeded Feb 13, 2024 in 0s

71.51% (target 70.00%)

View this Pull Request on Codecov

71.51% (target 70.00%)

Details

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (76ae14a) 71.41% compared to head (636440a) 71.51%.
Report is 1 commits behind head on main.

❗ Current head 636440a differs from pull request most recent head a231a63. Consider uploading reports for the commit a231a63 to get more accurate results

Files Patch % Lines
.../action/search/WrappingSearchAsyncActionPhase.java 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12293      +/-   ##
============================================
+ Coverage     71.41%   71.51%   +0.10%     
- Complexity    59813    59871      +58     
============================================
  Files          4959     4960       +1     
  Lines        281126   281127       +1     
  Branches      40857    40858       +1     
============================================
+ Hits         200753   201038     +285     
+ Misses        63731    63380     -351     
- Partials      16642    16709      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.