Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of special WrappingSearchAsyncActionPhase so the onPhaseStart() will always be followed by onPhaseEnd() within AbstractSearchAsyncAction #12293

Merged
merged 3 commits into from
Feb 16, 2024

Address code review comments

636440a
Select commit
Loading
Failed to load commit list.
Merged

Add support of special WrappingSearchAsyncActionPhase so the onPhaseStart() will always be followed by onPhaseEnd() within AbstractSearchAsyncAction #12293

Address code review comments
636440a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Feb 13, 2024 in 0s

92.30% of diff hit (target 71.41%)

View this Pull Request on Codecov

92.30% of diff hit (target 71.41%)

Annotations

Check warning on line 33 in server/src/main/java/org/opensearch/action/search/WrappingSearchAsyncActionPhase.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/action/search/WrappingSearchAsyncActionPhase.java#L33 

Added line #L33 was not covered by tests
View more details on Codecov