Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Workspace] fix: hide collaborators page on nav when newHomePage is disabled #9117

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
+8 −1
Open

[Backport 2.x] [Workspace] fix: hide collaborators page on nav when newHomePage is disabled #9117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/9116.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- Hide collaborators page on nav when newHomePage is disabled ([#9116](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9116))
7 changes: 6 additions & 1 deletion src/plugins/workspace/public/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,12 @@
this.coreStart = core;
const isPermissionEnabled = core?.application?.capabilities.workspaces.permissionEnabled;
this.collaboratorsAppUpdater$.next(() => {
return { status: isPermissionEnabled ? AppStatus.accessible : AppStatus.inaccessible };
return {

Check warning on line 599 in src/plugins/workspace/public/plugin.ts

View check run for this annotation

Codecov / codecov/patch

src/plugins/workspace/public/plugin.ts#L599 

Added line #L599 was not covered by tests
status: isPermissionEnabled ? AppStatus.accessible : AppStatus.inaccessible,
navLinkStatus: core.chrome.navGroup.getNavGroupEnabled()
? AppNavLinkStatus.visible
: AppNavLinkStatus.hidden,
};
});

this.currentWorkspaceIdSubscription = this._changeSavedObjectCurrentWorkspace();
Expand Down
Loading