Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Workspace] fix: hide collaborators page on nav when newHomePage is disabled #9117

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b603c21 from #9116.

…isabled (#9116)

* fix: fix collaborators page on nav when newHomePage is disabled

Signed-off-by: tygao <[email protected]>

* Changeset file for PR #9116 created/updated

---------

Signed-off-by: tygao <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit b603c21)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.87%. Comparing base (1050dee) to head (fd6d57b).

Files with missing lines Patch % Lines
src/plugins/workspace/public/plugin.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #9117   +/-   ##
=======================================
  Coverage   60.87%   60.87%           
=======================================
  Files        3807     3807           
  Lines       91112    91114    +2     
  Branches    14375    14376    +1     
=======================================
+ Hits        55468    55470    +2     
- Misses      32116    32117    +1     
+ Partials     3528     3527    -1     
Flag Coverage Δ
Linux_1 29.01% <0.00%> (-0.01%) ⬇️
Linux_2 56.52% <ø> (ø)
Linux_3 37.84% <ø> (?)
Linux_4 30.02% <ø> (ø)
Windows_1 29.02% <0.00%> (-0.01%) ⬇️
Windows_2 56.48% <ø> (ø)
Windows_3 37.84% <ø> (ø)
Windows_4 30.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor autocut Skip the changelog verification check on backports failed changeset v2.19.0 workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants