Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Use HTTP service instead of fetch for plugin check #9052

Merged
merged 6 commits into from
Jan 9, 2025
Merged

[Enhancement] Use HTTP service instead of fetch for plugin check #9052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
91e1bc1
Use HTTP service instead of fetch
RyanL1997 Dec 11, 2024
a6bc98d
resolve comments
RyanL1997 Jan 7, 2025
02b2067
Add mock for addDanger()
RyanL1997 Jan 8, 2025
bb3a5cd
Add unit test for sql definition preview
RyanL1997 Jan 9, 2025
124a8e3
Fix the typo of class title O_o
RyanL1997 Jan 9, 2025
63f8378
Fix the snapshot issue
RyanL1997 Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...t_query_data_sources_components/acceleration_creation/create/create_acceleration.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ const mockNotifications = {
toasts: {
addWarning: jest.fn(),
addSuccess: jest.fn(),
addDanger: jest.fn(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: there are common mocks from core, we can leverage that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. For the latest test cases I just added, I switched to use coreMock instead. And for this one and the rest of the entire test suites of this plugin, lets open a separate PR as follow up.

},
};

Expand Down
3 changes: 2 additions & 1 deletion ...direct_query_data_sources_components/acceleration_creation/create/create_acceleration.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import { CatalogCacheManager } from '../../../../../framework/catalog_cache/cach
import { IndexAdvancedSettings } from '../selectors/index_advanced_settings';
import { IndexSettingOptions } from '../selectors/index_setting_options';
import { IndexTypeSelector } from '../selectors/index_type_selector';
import { PreviewSQLDefinition } from '../selectors/preview_sql_defintion';
import { PreviewSQLDefinition } from '../selectors/preview_sql_definition';
import { AccelerationDataSourceSelector } from '../selectors/source_selector';
import { QueryVisualEditor } from '../visual_editors/query_visual_editor';
import { CreateAccelerationButton } from './create_acceleration_button';
Expand Down Expand Up @@ -277,6 +277,7 @@ export const CreateAcceleration = ({
resetFlyout={resetFlyout}
notifications={notifications}
application={application}
http={http}
/>
</EuiForm>
</EuiFlyoutBody>
Expand Down
339 changes: 339 additions & 0 deletions ...onents/acceleration_creation/selectors/__snapshots__/preview_sql_definition.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading