[Enhancement] Use HTTP service instead of fetch for plugin check #9052

RyanL1997 · 2024-12-13T07:45:35Z

Description

Use HTTP service instead of fetch for plugin check

Issues Resolved

Resolve [BUG] SQL Query Workbench Plugin Status Check Failure in Direct Query Datasource #9032
In addition, I noticed that the previous naming of preview_sql_definition was mis-spelled as preview_sql_defintion, so I have also changed that and its related usage.

Screenshot

Testing the changes

Changelog

fix: [Enhancement] Use HTTP service instead of fetch for plugin check [Enhancement] Use HTTP service instead of fetch for plugin check #9052

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

github-actions · 2024-12-13T07:46:08Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

codecov · 2024-12-13T08:00:45Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.99%. Comparing base (c382d1a) to head (63f8378).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9052      +/-   ##
==========================================
+ Coverage   60.97%   60.99%   +0.02%     
==========================================
  Files        3812     3812              
  Lines       91358    91357       -1     
  Branches    14435    14435              
==========================================
+ Hits        55703    55725      +22     
+ Misses      32099    32078      -21     
+ Partials     3556     3554       -2

Flag	Coverage Δ
Linux_1	`29.05% <0.00%> (+<0.01%)`	⬆️
Linux_2	`56.45% <ø> (ø)`
Linux_3	`38.00% <100.00%> (+0.03%)`	⬆️
Linux_4	`29.03% <0.00%> (+<0.01%)`	⬆️
Windows_1	`29.07% <0.00%> (+<0.01%)`	⬆️
Windows_2	`56.40% <ø> (ø)`
Windows_3	`38.00% <100.00%> (?)`
Windows_4	`29.03% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-12-17T18:06:39Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

...rect_query_data_sources_components/acceleration_creation/selectors/preview_sql_defintion.tsx

SuZhou-Joe · 2025-01-08T06:48:54Z

...rect_query_data_sources_components/acceleration_creation/create/create_acceleration.test.tsx

@@ -26,6 +26,7 @@ const mockNotifications = {
  toasts: {
    addWarning: jest.fn(),
    addSuccess: jest.fn(),
+    addDanger: jest.fn(),


Nit: there are common mocks from core, we can leverage that.

Good suggestion. For the latest test cases I just added, I switched to use coreMock instead. And for this one and the rest of the entire test suites of this plugin, lets open a separate PR as follow up.

Signed-off-by: Jialiang Liang <[email protected]>

RyanL1997 · 2025-01-09T00:40:22Z

* [ERR] [https://yarnpkg.com/lang/en/docs/workspaces/](https://yarnpkg.com/lang/en/docs/workspaces/) | Failed: Network error: error sending request for url (https://classic.yarnpkg.com/en/docs/workspaces/)

Error: Process completed with exit code 2.

The above link checker failure is not related to this change

Signed-off-by: Jialiang Liang <[email protected]>

* Use HTTP service instead of fetch Signed-off-by: Jialiang Liang <[email protected]> * resolve comments Signed-off-by: Jialiang Liang <[email protected]> * Add mock for addDanger() Signed-off-by: Jialiang Liang <[email protected]> * Add unit test for sql definition preview Signed-off-by: Jialiang Liang <[email protected]> * Fix the typo of class title O_o Signed-off-by: Jialiang Liang <[email protected]> * Fix the snapshot issue Signed-off-by: Jialiang Liang <[email protected]> --------- Signed-off-by: Jialiang Liang <[email protected]> (cherry picked from commit f7ecf99) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…) (#9165) * Use HTTP service instead of fetch * resolve comments * Add mock for addDanger() * Add unit test for sql definition preview * Fix the typo of class title O_o * Fix the snapshot issue --------- (cherry picked from commit f7ecf99) Signed-off-by: Jialiang Liang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…nsearch-project#9052) * Use HTTP service instead of fetch Signed-off-by: Jialiang Liang <[email protected]> * resolve comments Signed-off-by: Jialiang Liang <[email protected]> * Add mock for addDanger() Signed-off-by: Jialiang Liang <[email protected]> * Add unit test for sql definition preview Signed-off-by: Jialiang Liang <[email protected]> * Fix the typo of class title O_o Signed-off-by: Jialiang Liang <[email protected]> * Fix the snapshot issue Signed-off-by: Jialiang Liang <[email protected]> --------- Signed-off-by: Jialiang Liang <[email protected]>

github-actions bot added the seasoned-contributor label Dec 13, 2024

github-actions bot added the failed changeset label Dec 13, 2024

RyanL1997 changed the title ~~[WIP] Use HTTP service instead of fetch for plugin check~~ Use HTTP service instead of fetch for plugin check Dec 17, 2024

RyanL1997 marked this pull request as ready for review December 17, 2024 18:06

opensearch-changeset-bot bot added a commit to RyanL1997/OpenSearch-Dashboards that referenced this pull request Dec 18, 2024

Changeset file for PR opensearch-project#9052 created/updated

1208f40

github-actions bot removed the failed changeset label Dec 18, 2024

ruanyl reviewed Dec 26, 2024

View reviewed changes

...rect_query_data_sources_components/acceleration_creation/selectors/preview_sql_defintion.tsx Outdated Show resolved Hide resolved

RyanL1997 force-pushed the mds-flint-plugin-check-fix branch from 1208f40 to 3b3c15e Compare January 7, 2025 20:33

RyanL1997 added the backport 2.x label Jan 7, 2025

ruanyl previously approved these changes Jan 8, 2025

View reviewed changes

SuZhou-Joe previously approved these changes Jan 8, 2025

View reviewed changes

RyanL1997 dismissed stale reviews from SuZhou-Joe and ruanyl via 5898602 January 8, 2025 04:48

SuZhou-Joe reviewed Jan 8, 2025

View reviewed changes

...rect_query_data_sources_components/acceleration_creation/selectors/preview_sql_defintion.tsx Show resolved Hide resolved

SuZhou-Joe reviewed Jan 8, 2025

View reviewed changes

SuZhou-Joe previously approved these changes Jan 8, 2025

View reviewed changes

RyanL1997 dismissed SuZhou-Joe’s stale review via f18161e January 9, 2025 00:22

RyanL1997 force-pushed the mds-flint-plugin-check-fix branch from 70c20b5 to 92ea4fb Compare January 9, 2025 00:31

opensearch-changeset-bot bot added a commit to RyanL1997/OpenSearch-Dashboards that referenced this pull request Jan 9, 2025

Changeset file for PR opensearch-project#9052 created/updated

b361afe

RyanL1997 added 5 commits January 8, 2025 16:35

Use HTTP service instead of fetch

91e1bc1

Signed-off-by: Jialiang Liang <[email protected]>

resolve comments

a6bc98d

Signed-off-by: Jialiang Liang <[email protected]>

Add mock for addDanger()

02b2067

Signed-off-by: Jialiang Liang <[email protected]>

Add unit test for sql definition preview

bb3a5cd

Signed-off-by: Jialiang Liang <[email protected]>

Fix the typo of class title O_o

124a8e3

Signed-off-by: Jialiang Liang <[email protected]>

RyanL1997 force-pushed the mds-flint-plugin-check-fix branch from b361afe to 124a8e3 Compare January 9, 2025 00:38

Fix the snapshot issue

63f8378

Signed-off-by: Jialiang Liang <[email protected]>

SuZhou-Joe approved these changes Jan 9, 2025

View reviewed changes

ruanyl approved these changes Jan 9, 2025

View reviewed changes

ruanyl merged commit f7ecf99 into opensearch-project:main Jan 9, 2025
69 checks passed

opensearch-trigger-bot bot mentioned this pull request Jan 9, 2025

[Backport 2.x] [Enhancement] Use HTTP service instead of fetch for plugin check #9165

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement] Use HTTP service instead of fetch for plugin check #9052

[Enhancement] Use HTTP service instead of fetch for plugin check #9052

RyanL1997 commented Dec 13, 2024 •

edited

Loading

github-actions bot commented Dec 13, 2024

codecov bot commented Dec 13, 2024 •

edited

Loading

github-actions bot commented Dec 17, 2024

SuZhou-Joe Jan 8, 2025

RyanL1997 Jan 9, 2025

RyanL1997 commented Jan 9, 2025

[Enhancement] Use HTTP service instead of fetch for plugin check #9052

[Enhancement] Use HTTP service instead of fetch for plugin check #9052

Conversation

RyanL1997 commented Dec 13, 2024 • edited Loading

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

github-actions bot commented Dec 13, 2024

❌ Empty Changelog Section

codecov bot commented Dec 13, 2024 • edited Loading

Codecov Report

github-actions bot commented Dec 17, 2024

❌ Empty Changelog Section

SuZhou-Joe Jan 8, 2025

Choose a reason for hiding this comment

RyanL1997 Jan 9, 2025

Choose a reason for hiding this comment

RyanL1997 commented Jan 9, 2025

RyanL1997 commented Dec 13, 2024 •

edited

Loading

codecov bot commented Dec 13, 2024 •

edited

Loading