Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix a typo while inspecting values for large numerals in OSD and the JS client #8875

Merged
merged 2 commits into from
Dec 11, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update postinstall.js
Signed-off-by: Miki <[email protected]>
AMoo-Miki authored Nov 18, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 967906997074b859c15dbc97beb3a22d4d760d89
2 changes: 1 addition & 1 deletion scripts/postinstall.js
Original file line number Diff line number Diff line change
@@ -86,7 +86,7 @@ const run = async () => {
);
//ToDo: Remove when opensearch-js is released to include https://github.com/opensearch-project/opensearch-js/pull/889
promises.push(
patchFile('node_modules/@opensearch-project/opensearch/lib/Serializer.js', [
patchFile('node_modules/@opensearch-project/opensearch-next/lib/Serializer.js', [
{
from: 'val < Number.MAX_SAFE_INTEGER',
to: 'val < Number.MIN_SAFE_INTEGER',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems js client had a release, is this still needed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can raise another PR if it's not needed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8886 bump to 2.13.0 marked with label 3.0.0, we might need to keep it for 2.x

Copy link
Collaborator

@AMoo-Miki AMoo-Miki Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.x uses the JS client with a -next suffix so the change has to be manually ported to 2.x. When done, the unnecessary parts will be removed.