[Backport 2.x] Fix a typo while inspecting values for large numerals in OSD and the JS client #8875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…JS client (#8839) * [@osd/std] Fix typo while inspecting values for large numerals Signed-off-by: Miki <[email protected]> * Patch @opensearch-project/opensearch to fix a typo Ref: opensearch-project/opensearch-js#889 Signed-off-by: Miki <[email protected]> * Changeset file for PR #8839 created/updated --------- Signed-off-by: Miki <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit e993d24) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #8875 +/- ##
==========================================
+ Coverage 60.94% 60.98% +0.04%
==========================================
Files 3799 3799
Lines 90829 90856 +27
Branches 14296 14306 +10
==========================================
+ Hits 55356 55413 +57
+ Misses 31963 31929 -34
- Partials 3510 3514 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kavilla
previously approved these changes
Nov 15, 2024
Signed-off-by: Miki <[email protected]>
joshuali925
approved these changes
Nov 29, 2024
| patchFile('node_modules/@opensearch-project/opensearch-next/lib/Serializer.js', [ | ||
| { | ||
| from: 'val < Number.MAX_SAFE_INTEGER', | ||
| to: 'val < Number.MIN_SAFE_INTEGER', |
There was a problem hiding this comment.
seems js client had a release, is this still needed?
There was a problem hiding this comment.
I guess we can raise another PR if it's not needed?
There was a problem hiding this comment.
#8886 bump to 2.13.0 marked with label 3.0.0, we might need to keep it for 2.x
There was a problem hiding this comment.
2.x uses the JS client with a -next suffix so the change has to be manually ported to 2.x. When done, the unnecessary parts will be removed.
LDrago27
approved these changes
Nov 29, 2024
ruanyl
approved these changes
Dec 4, 2024
Hailong-am
approved these changes
Dec 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
…in OSD and the JS client (#8875) * Fix a typo while inspecting values for large numerals in OSD and the JS client (#8839) * [@osd/std] Fix typo while inspecting values for large numerals Signed-off-by: Miki <[email protected]> * Patch @opensearch-project/opensearch to fix a typo Ref: opensearch-project/opensearch-js#889 Signed-off-by: Miki <[email protected]> * Changeset file for PR #8839 created/updated --------- Signed-off-by: Miki <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit e993d24) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update postinstall.js Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]> (cherry picked from commit cd2faad) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
…in OSD and the JS client (#8875) * Fix a typo while inspecting values for large numerals in OSD and the JS client (#8839) * [@osd/std] Fix typo while inspecting values for large numerals Signed-off-by: Miki <[email protected]> * Patch @opensearch-project/opensearch to fix a typo Ref: opensearch-project/opensearch-js#889 Signed-off-by: Miki <[email protected]> * Changeset file for PR #8839 created/updated --------- Signed-off-by: Miki <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit e993d24) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update postinstall.js Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]> (cherry picked from commit cd2faad) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
…in OSD and the JS client (#8875) * Fix a typo while inspecting values for large numerals in OSD and the JS client (#8839) * [@osd/std] Fix typo while inspecting values for large numerals Signed-off-by: Miki <[email protected]> * Patch @opensearch-project/opensearch to fix a typo Ref: opensearch-project/opensearch-js#889 Signed-off-by: Miki <[email protected]> * Changeset file for PR #8839 created/updated --------- Signed-off-by: Miki <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit e993d24) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update postinstall.js Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]> (cherry picked from commit cd2faad) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki
added a commit
that referenced
this pull request
Dec 11, 2024
…in OSD and the JS client (#8875) (#9037) * Fix a typo while inspecting values for large numerals in OSD and the JS client (#8839) * [@osd/std] Fix typo while inspecting values for large numerals * Patch @opensearch-project/opensearch to fix a typo Ref: opensearch-project/opensearch-js#889 * Changeset file for PR #8839 created/updated --------- (cherry picked from commit e993d24) * Update postinstall.js --------- (cherry picked from commit cd2faad) Signed-off-by: Miki <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e993d24 from #8839.