Add discover summary error info and button click logic enhancement #8352
Conversation
Signed-off-by: Liyun Xiu <[email protected]>
chishui
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Signed-off-by: Liyun Xiu <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8352 +/- ##
==========================================
- Coverage 60.93% 60.91% -0.03%
==========================================
Files 3756 3756
Lines 89225 89232 +7
Branches 13950 13954 +4
==========================================
- Hits 54373 54354 -19
- Misses 31469 31538 +69
+ Partials 3383 3340 -43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/plugins/query_enhancements/public/query_assist/components/query_assist_summary.tsx
Outdated
Show resolved
Hide resolved
src/plugins/query_enhancements/public/query_assist/components/query_assist_summary.tsx
Show resolved
Hide resolved
src/plugins/query_enhancements/public/query_assist/components/query_assist_summary.tsx
Outdated
Show resolved
Hide resolved
| export const QueryAssistSummary: React.FC<QueryAssistSummaryProps> = (props) => { | ||
| const { query, search } = props.data; | ||
| const [summary, setSummary] = useState(null); // store fetched data |
There was a problem hiding this comment.
do we know for sure the summary will never be ''. null for me implies no summary was retrieved where as if the summary was an empty string the user might not be able to give feedback on the summary even though the information can be used to capture cases where query assist didn't output any summary.
There was a problem hiding this comment.
In case LLM fails to generate summary, we would render an error message. But if LLM is able to generate summary, I believe there's always some outputs.
| @@ -76,6 +82,9 @@ export const QueryAssistSummary: React.FC<QueryAssistSummaryProps> = (props) => | |||
| defaultMessage: | |||
| 'Thank you for the feedback. Try again by adjusting your question so that I have the opportunity to better assist you.', | |||
| }); | |||
| const errorPrompt = i18n.translate('queryEnhancements.queryAssist.summary.errorPrompt', { | |||
There was a problem hiding this comment.
should we consider adding : Try again by adjusting your question so that I have the opportunity to better assist you.
Or do we have an error message that we can display to the user for more insight?
There was a problem hiding this comment.
Some errors are not caused by questions, it might be frustrating when there's backend issue but we keep asking users to change questions.
|
does this go to 2.18? 2.17 next? |
|
@chishui @ruanyl @joshuali925 @opensearch-project/opensearch-ux should we add a retry button? does query assist support retries with the context that the user didn't think the summary was good enough and will try again? or will it just give back the same summary |
We'll have a new UI which is to add such button to regenerate summary, will make change once receives new design. |
Signed-off-by: Liyun Xiu <[email protected]>
ashwin-pc
added
discover-next
v2.18.0
and removed
discover
|
Lets add |
|
@kavilla @ruanyl @ashwin-pc if you guys have no other questions on this PR, could you help approve? |
Description
Improve some logic for discover query assist summary.
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration