Address comments

Signed-off-by: Liyun Xiu <[email protected]>
opensearch-project · Sep 27, 2024 · 1b5b3a0 · 1b5b3a0
1 parent d8fa9cc
commit 1b5b3a0
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 15 deletions.
diff --git a/src/plugins/query_enhancements/common/query_assist/index.ts b/src/plugins/query_enhancements/common/query_assist/index.ts
@@ -3,4 +3,9 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-export { QueryAssistParameters, QueryAssistResponse, QueryAssistContextType } from './types';
+export {
+ QueryAssistParameters,
+ QueryAssistResponse,
+ QueryAssistContextType,
+ FeedbackStatus,
+} from './types';
diff --git a/src/plugins/query_enhancements/common/query_assist/types.ts b/src/plugins/query_enhancements/common/query_assist/types.ts
@@ -23,3 +23,9 @@ export enum QueryAssistContextType {
  QUERY,
  DATA,
 }
+
+export enum FeedbackStatus {
+ NONE = 'none',
+ THUMB_UP = 'thumbup',
+ THUMB_DOWN = 'thumbdown',
+}
diff --git a/src/plugins/query_enhancements/public/query_assist/components/query_assist_summary.test.tsx b/src/plugins/query_enhancements/public/query_assist/components/query_assist_summary.test.tsx
@@ -9,6 +9,7 @@ import { BehaviorSubject } from 'rxjs';
 import { QueryAssistSummary, convertResult } from './query_assist_summary';
 import { useQueryAssist } from '../hooks';
 import { IDataFrame, Query } from '../../../../data/common';
+import { FeedbackStatus as FEEDBACK } from '../../../common/query_assist';
 
 jest.mock('react', () => ({
  ...jest.requireActual('react'),
@@ -90,12 +91,6 @@ describe('query assist summary', () => {
  NO: false,
  };
 
- enum FEEDBACK {
- NONE,
- THUMB_UP,
- THUMB_DOWN,
- }
-
  const renderQueryAssistSummary = (isCollapsed: boolean) => {
  const component = render(
  <div>

diff --git a/src/plugins/query_enhancements/public/query_assist/components/query_assist_summary.tsx b/src/plugins/query_enhancements/public/query_assist/components/query_assist_summary.tsx
@@ -29,6 +29,7 @@ import { CoreSetup } from '../../../../../core/public';
 import { QueryAssistContextType } from '../../../common/query_assist';
 import sparkleHollowSvg from '../../assets/sparkle_hollow.svg';
 import sparkleSolidSvg from '../../assets/sparkle_solid.svg';
+import { FeedbackStatus } from '../../../common/query_assist';
 
 export interface QueryContext {
  question: string;
@@ -63,12 +64,6 @@ export const convertResult = (body: IDataFrame) => {
  return hits;
 };
 
-enum FeedbackStatus {
- NONE,
- THUMB_UP,
- THUMB_DOWN,
-}
-
 export const QueryAssistSummary: React.FC<QueryAssistSummaryProps> = (props) => {
  const { query, search } = props.data;
  const [summary, setSummary] = useState(''); // store fetched data
@@ -214,8 +209,9 @@ export const QueryAssistSummary: React.FC<QueryAssistSummaryProps> = (props) =>
  const onFeedback = useCallback(
  (satisfied: boolean) => {
  if (feedback !== FeedbackStatus.NONE) return;
- setFeedback(satisfied ? FeedbackStatus.THUMB_UP : FeedbackStatus.THUMB_DOWN);
- reportMetric(satisfied ? 'thumbup' : 'thumbdown');
+ const feedbackStatus = satisfied ? FeedbackStatus.THUMB_UP : FeedbackStatus.THUMB_DOWN;
+ setFeedback(feedbackStatus);
+ reportMetric(feedbackStatus);
  },
  [feedback, reportMetric]
  );