Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Fix fit&finish for workspace overview page #8139

Merged
merged 28 commits into from
Sep 30, 2024

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Sep 11, 2024

Description

  • wording change for workspace overview page
  • getting started card typography using h4 with s size
  • show recently access & updated assets only for current workspace
  • hide workspace name in recently assets card when in a workspace
  • Use doc link service to get links
  • Recently updated assets use find to search by update_at instead of use recently accessed

Issues Resolved

Screenshot

Untitled.mov

Testing the changes

  1. enable workspace and new home in opensearch_dashboards.yml file
workspace.enabled: true
uiSettings:
  overrides:
    "home:useNewHomePage": true
  1. start OSD with yarn start --no-base-path
  2. create workspace with essential use case
  3. verify content in workspace overview page

Changelog

  • fix: fix fit & finish for workspace overview getting started and assets section

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 70.27027% with 22 lines in your changes missing coverage. Please review.

Project coverage is 60.92%. Comparing base (b8b563d) to head (ecf295a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...nagement/public/management_section/recent_work.tsx 74.60% 5 Missing and 11 partials ⚠️
...nt_management/public/components/section_render.tsx 20.00% 4 Missing ⚠️
...blic/components/card_container/card_embeddable.tsx 0.00% 0 Missing and 1 partial ⚠️
src/plugins/home/public/plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8139   +/-   ##
=======================================
  Coverage   60.92%   60.92%           
=======================================
  Files        3750     3750           
  Lines       89054    89095   +41     
  Branches    13910    13923   +13     
=======================================
+ Hits        54257    54285   +28     
- Misses      31433    31436    +3     
- Partials     3364     3374   +10     
Flag Coverage Δ
Linux_1 28.84% <4.05%> (-0.02%) ⬇️
Linux_2 56.35% <ø> (ø)
Linux_3 37.72% <5.40%> (-0.03%) ⬇️
Linux_4 29.96% <68.91%> (+<0.01%) ⬆️
Windows_1 28.85% <4.05%> (-0.02%) ⬇️
Windows_2 56.30% <ø> (ø)
Windows_3 37.73% <5.40%> (-0.03%) ⬇️
Windows_4 29.96% <68.91%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kavilla
kavilla previously approved these changes Sep 12, 2024
@ruanyl ruanyl added 2.17.1 and removed v2.18.0 labels Sep 19, 2024
@@ -115,7 +117,7 @@ export const registerContentToSearchUseCasePage = (
});
});

const searchIcon = <EuiIcon color="subdued" size="l" type="search" />;
const searchIcon = <EuiIcon color="#9FC4D2" size="l" type="search" />;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we not hard code the color? Just wondering how it will look like under dark/light mode?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dark mode
image

light mode
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ouiLinkColor Shall we use this variable?

https://oui.opensearch.org/1.14/#/guidelines/sass

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ouiLinkColor Shall we use this variable?

https://oui.opensearch.org/1.14/#/guidelines/sass

let me see if I can use predefined variables

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to a custom color by leveraging oui variable color: tint($euiLinkColor, 50%);

SuZhou-Joe
SuZhou-Joe previously approved these changes Sep 29, 2024
Signed-off-by: Hailong Cui <[email protected]>
@Hailong-am Hailong-am dismissed stale reviews from SuZhou-Joe and ruanyl via 81ed6cb September 29, 2024 09:24
@ruanyl ruanyl merged commit 69ec279 into opensearch-project:main Sep 30, 2024
65 of 67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 30, 2024
* fit&finish for workspace overview page

Signed-off-by: Hailong Cui <[email protected]>

* Changeset file for PR #8139 created/updated

* revert recent_items.tsx change

Signed-off-by: Hailong Cui <[email protected]>

* use doclink service to build links

Signed-off-by: Hailong Cui <[email protected]>

* remove commented urls

Signed-off-by: Hailong Cui <[email protected]>

* update getting started card title size

Signed-off-by: Hailong Cui <[email protected]>

* update getting started card title size

Signed-off-by: Hailong Cui <[email protected]>

* recently updated assets

Signed-off-by: Hailong Cui <[email protected]>

* update card title size

Signed-off-by: Hailong Cui <[email protected]>

* Changeset file for PR #8139 created/updated

* address review comments

Signed-off-by: Hailong Cui <[email protected]>

* fix for search overview page

Signed-off-by: Hailong Cui <[email protected]>

* wrap the card title

Signed-off-by: Hailong Cui <[email protected]>

* make getting started card not collapseable

Signed-off-by: Hailong Cui <[email protected]>

* udpate getting started card title size

Signed-off-by: Hailong Cui <[email protected]>

* address review comments

Signed-off-by: Hailong Cui <[email protected]>

* address review comments

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 69ec279)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Sep 30, 2024
* fit&finish for workspace overview page



* Changeset file for PR #8139 created/updated

* revert recent_items.tsx change



* use doclink service to build links



* remove commented urls



* update getting started card title size



* update getting started card title size



* recently updated assets



* update card title size



* Changeset file for PR #8139 created/updated

* address review comments



* fix for search overview page



* wrap the card title



* make getting started card not collapseable



* udpate getting started card title size



* address review comments



* address review comments



---------



(cherry picked from commit 69ec279)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 3, 2024
…oject#8139) (opensearch-project#8386)

* fit&finish for workspace overview page



* Changeset file for PR opensearch-project#8139 created/updated

* revert recent_items.tsx change



* use doclink service to build links



* remove commented urls



* update getting started card title size



* update getting started card title size



* recently updated assets



* update card title size



* Changeset file for PR opensearch-project#8139 created/updated

* address review comments



* fix for search overview page



* wrap the card title



* make getting started card not collapseable



* udpate getting started card title size



* address review comments



* address review comments



---------



(cherry picked from commit 69ec279)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants