Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Workspace] Fix fit&finish for workspace overview page #8386

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 69ec279 from #8139.

* fit&finish for workspace overview page

Signed-off-by: Hailong Cui <[email protected]>

* Changeset file for PR #8139 created/updated

* revert recent_items.tsx change

Signed-off-by: Hailong Cui <[email protected]>

* use doclink service to build links

Signed-off-by: Hailong Cui <[email protected]>

* remove commented urls

Signed-off-by: Hailong Cui <[email protected]>

* update getting started card title size

Signed-off-by: Hailong Cui <[email protected]>

* update getting started card title size

Signed-off-by: Hailong Cui <[email protected]>

* recently updated assets

Signed-off-by: Hailong Cui <[email protected]>

* update card title size

Signed-off-by: Hailong Cui <[email protected]>

* Changeset file for PR #8139 created/updated

* address review comments

Signed-off-by: Hailong Cui <[email protected]>

* fix for search overview page

Signed-off-by: Hailong Cui <[email protected]>

* wrap the card title

Signed-off-by: Hailong Cui <[email protected]>

* make getting started card not collapseable

Signed-off-by: Hailong Cui <[email protected]>

* udpate getting started card title size

Signed-off-by: Hailong Cui <[email protected]>

* address review comments

Signed-off-by: Hailong Cui <[email protected]>

* address review comments

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 69ec279)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 71.23288% with 21 lines in your changes missing coverage. Please review.

Project coverage is 61.01%. Comparing base (16fbc1e) to head (8d415c8).
Report is 7 commits behind head on 2.x.

Files with missing lines Patch % Lines
...nagement/public/management_section/recent_work.tsx 74.60% 5 Missing and 11 partials ⚠️
...nt_management/public/components/section_render.tsx 20.00% 4 Missing ⚠️
...blic/components/card_container/card_embeddable.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #8386   +/-   ##
=======================================
  Coverage   61.00%   61.01%           
=======================================
  Files        3747     3747           
  Lines       89024    89080   +56     
  Branches    13894    13909   +15     
=======================================
+ Hits        54309    54351   +42     
- Misses      31356    31406   +50     
+ Partials     3359     3323   -36     
Flag Coverage Δ
Linux_1 28.84% <4.10%> (-0.02%) ⬇️
Linux_2 56.46% <ø> (ø)
Linux_3 37.76% <5.47%> (-0.03%) ⬇️
Linux_4 30.08% <69.86%> (+0.02%) ⬆️
Windows_1 28.86% <4.10%> (-0.02%) ⬇️
Windows_2 56.41% <ø> (ø)
Windows_3 37.76% <5.47%> (-0.03%) ⬇️
Windows_4 30.08% <69.86%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 45dd521 into 2.x Sep 30, 2024
68 of 70 checks passed
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 3, 2024
…oject#8139) (opensearch-project#8386)

* fit&finish for workspace overview page



* Changeset file for PR opensearch-project#8139 created/updated

* revert recent_items.tsx change



* use doclink service to build links



* remove commented urls



* update getting started card title size



* update getting started card title size



* recently updated assets



* update card title size



* Changeset file for PR opensearch-project#8139 created/updated

* address review comments



* fix for search overview page



* wrap the card title



* make getting started card not collapseable



* udpate getting started card title size



* address review comments



* address review comments



---------



(cherry picked from commit 69ec279)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.17.1 all-star-contributor autocut Skip the changelog verification check on backports failed changeset workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants