Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.17] [Backport 2.x] [Workspace] Enable direct query connections to support in workspace #8048

Merged
merged 1 commit into from
Sep 6, 2024

[Workspace] Enable direct query connections to support in workspace (…

85b0178
Select commit
Loading
Failed to load commit list.
Merged

[Backport 2.17] [Backport 2.x] [Workspace] Enable direct query connections to support in workspace #8048

[Workspace] Enable direct query connections to support in workspace (…
85b0178
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 6, 2024 in 1s

60.60% (+0.03%) compared to e35f80e

View this Pull Request on Codecov

60.60% (+0.03%) compared to e35f80e

Details

Codecov Report

Attention: Patch coverage is 87.50000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 60.60%. Comparing base (e35f80e) to head (85b0178).

Files with missing lines Patch % Lines
...ents/workspace_detail/select_data_source_panel.tsx 80.64% 2 Missing and 4 partials ⚠️
src/plugins/workspace/public/utils.ts 73.91% 6 Missing ⚠️
...workspace_detail/association_data_source_modal.tsx 90.00% 3 Missing and 2 partials ⚠️
.../workspace_detail/data_source_connection_table.tsx 96.49% 1 Missing and 1 partial ⚠️
...ts/workspace_form/direct_query_connection_icon.tsx 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             2.17    #8048      +/-   ##
==========================================
+ Coverage   60.56%   60.60%   +0.03%     
==========================================
  Files        3726     3727       +1     
  Lines       88171    88275     +104     
  Branches    13630    13657      +27     
==========================================
+ Hits        53400    53497      +97     
- Misses      31524    31527       +3     
- Partials     3247     3251       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov