Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: order of query editor extensions not working #8045

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Sep 6, 2024

Description

When the react portal was created asynchronously within the same container, the order of query editor extensions cannot not be guaranteed. As react portal append the rendered component to the same container at the time when it's mounted. To fix the issue, now rendering the extension to different pre-ordered container.

This PR also introduced a few style changes so that multiple extensions can be render horizontally:
image

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: order of query editor extensions not working

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ruanyl ruanyl changed the title fix: order it query editor extensions not working fix: order of query editor extensions not working Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@ruanyl
Copy link
Member Author

ruanyl commented Sep 6, 2024

@joshuali925 @kavilla @ashwin-pc Could you take a look at this bug fix please, thanks!

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.59%. Comparing base (d9c9aad) to head (1e961cf).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8045      +/-   ##
==========================================
- Coverage   60.60%   60.59%   -0.02%     
==========================================
  Files        3732     3732              
  Lines       88427    88430       +3     
  Branches    13701    13701              
==========================================
- Hits        53589    53580       -9     
- Misses      31579    31590      +11     
- Partials     3259     3260       +1     
Flag Coverage Δ
Linux_1 28.75% <ø> (ø)
Linux_2 56.26% <ø> (ø)
Linux_3 37.44% <100.00%> (-0.01%) ⬇️
Linux_4 29.65% <ø> (+<0.01%) ⬆️
Windows_1 28.77% <ø> (-0.02%) ⬇️
Windows_2 56.21% <ø> (ø)
Windows_3 37.45% <100.00%> (+<0.01%) ⬆️
Windows_4 29.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@kavilla kavilla added v2.17.0 discover for discover reinvent labels Sep 6, 2024
@ruanyl ruanyl merged commit cedba8e into opensearch-project:main Sep 9, 2024
77 of 78 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 9, 2024
* fix: order it query editor extensions not working

Signed-off-by: Yulong Ruan <[email protected]>

* tweaks query assist extension styles

Signed-off-by: Yulong Ruan <[email protected]>

* Changeset file for PR #8045 created/updated

---------

Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit cedba8e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 9, 2024
* fix: order it query editor extensions not working

Signed-off-by: Yulong Ruan <[email protected]>

* tweaks query assist extension styles

Signed-off-by: Yulong Ruan <[email protected]>

* Changeset file for PR #8045 created/updated

---------

Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit cedba8e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla pushed a commit that referenced this pull request Sep 9, 2024
* fix: order it query editor extensions not working



* tweaks query assist extension styles



* Changeset file for PR #8045 created/updated

---------



(cherry picked from commit cedba8e)

Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
kavilla pushed a commit that referenced this pull request Sep 9, 2024
* fix: order it query editor extensions not working



* tweaks query assist extension styles



* Changeset file for PR #8045 created/updated

---------



(cherry picked from commit cedba8e)

Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants