Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: it should not create multiple query editor extension container #8085

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Sep 9, 2024

Description

This is a follow up of #8045. With this PR, it only creates the query extension container when the container not exists, this will avoid creating duplicate containers.

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

github-actions bot commented Sep 9, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@ruanyl
Copy link
Member Author

ruanyl commented Sep 9, 2024

@kavilla @joshuali925 Could you take a look at this PR? It fixed an issue introduced by #8045

Copy link
Contributor

github-actions bot commented Sep 9, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@github-actions github-actions bot added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.58%. Comparing base (ecd33b0) to head (bc21f92).
Report is 69 commits behind head on main.

Files with missing lines Patch % Lines
...uery_editor_extensions/query_editor_extensions.tsx 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8085   +/-   ##
=======================================
  Coverage   60.58%   60.58%           
=======================================
  Files        3738     3738           
  Lines       88671    88675    +4     
  Branches    13784    13785    +1     
=======================================
+ Hits        53722    53727    +5     
+ Misses      31663    31662    -1     
  Partials     3286     3286           
Flag Coverage Δ
Linux_1 28.76% <ø> (ø)
Linux_2 56.27% <ø> (ø)
Linux_3 37.52% <85.71%> (+<0.01%) ⬆️
Linux_4 29.60% <ø> (ø)
Windows_1 28.77% <ø> (ø)
Windows_2 56.22% <ø> (ø)
Windows_3 37.52% <85.71%> (+<0.01%) ⬆️
Windows_4 29.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit 9f76399 into opensearch-project:main Sep 10, 2024
136 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 10, 2024
…8085)

Signed-off-by: Yulong Ruan <[email protected]>
(cherry picked from commit 9f76399)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 10, 2024
…8085)

Signed-off-by: Yulong Ruan <[email protected]>
(cherry picked from commit 9f76399)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Sep 10, 2024
…8085) (#8103)

(cherry picked from commit 9f76399)

Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Sep 10, 2024
…8085) (#8104)

(cherry picked from commit 9f76399)

Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor backport 2.x backport 2.17 discover-next in-next Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants