-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: it should not create multiple query editor extension container #8085
fix: it should not create multiple query editor extension container #8085
Conversation
Signed-off-by: Yulong Ruan <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
@kavilla @joshuali925 Could you take a look at this PR? It fixed an issue introduced by #8045 |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8085 +/- ##
=======================================
Coverage 60.58% 60.58%
=======================================
Files 3738 3738
Lines 88671 88675 +4
Branches 13784 13785 +1
=======================================
+ Hits 53722 53727 +5
+ Misses 31663 31662 -1
Partials 3286 3286
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…8085) Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit 9f76399) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…8085) Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit 9f76399) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…8085) (#8103) (cherry picked from commit 9f76399) Signed-off-by: Yulong Ruan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…8085) (#8104) (cherry picked from commit 9f76399) Signed-off-by: Yulong Ruan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This is a follow up of #8045. With this PR, it only creates the query extension container when the container not exists, this will avoid creating duplicate containers.
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration