Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Add User level setting #7953

Merged
merged 32 commits into from
Sep 6, 2024

fix ut

5e83f3f
Select commit
Loading
Failed to load commit list.
Merged

[Workspace] Add User level setting #7953

fix ut
5e83f3f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 6, 2024 in 0s

60.59% (+0.00%) compared to d22b68b

View this Pull Request on Codecov

60.59% (+0.00%) compared to d22b68b

Details

Codecov Report

Attention: Patch coverage is 67.48971% with 79 lines in your changes missing coverage. Please review.

Project coverage is 60.59%. Comparing base (d22b68b) to head (5e83f3f).

Files with missing lines Patch % Lines
src/plugins/workspace/server/utils.ts 5.55% 17 Missing ⚠️
src/core/server/ui_settings/ui_settings_client.ts 77.55% 4 Missing and 7 partials ⚠️
...rkspace/public/components/workspace_list/index.tsx 80.39% 7 Missing and 3 partials ⚠️
src/plugins/advanced_settings/public/plugin.ts 43.75% 8 Missing and 1 partial ⚠️
...d_settings/public/management_app/user_settings.tsx 64.28% 4 Missing and 1 partial ⚠️
src/plugins/workspace/server/routes/index.ts 0.00% 5 Missing ⚠️
...ntent_management/public/components/page_render.tsx 55.55% 2 Missing and 2 partials ⚠️
src/plugins/workspace/public/plugin.ts 50.00% 3 Missing and 1 partial ⚠️
...r/saved_objects/user_ui_settings_client_wrapper.ts 91.89% 1 Missing and 2 partials ⚠️
...ade_saved_config/create_or_upgrade_saved_config.ts 66.66% 1 Missing and 1 partial ⚠️
... and 6 more
Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #7953    +/-   ##
========================================
  Coverage   60.58%   60.59%            
========================================
  Files        3732     3738     +6     
  Lines       88431    88636   +205     
  Branches    13702    13763    +61     
========================================
+ Hits        53579    53709   +130     
- Misses      31592    31650    +58     
- Partials     3260     3277    +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov