Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Add User level setting #7953

Merged
merged 32 commits into from
Sep 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
0a6312c
user level setting
Hailong-am Aug 24, 2024
060a5c3
add unit test
Hailong-am Sep 2, 2024
de214ec
add unit test
Hailong-am Sep 2, 2024
c2dd98e
Changeset file for PR #7953 created/updated
opensearch-changeset-bot[bot] Sep 2, 2024
80fc1dc
replace with constant DEFAULT_WORKSPACE
Hailong-am Sep 2, 2024
fd3f6de
Merge branch 'main' into use_level_settings
Hailong-am Sep 3, 2024
b3e2acf
update test snapshot
Hailong-am Sep 3, 2024
32becd6
update incorrect type in test data
Hailong-am Sep 3, 2024
af15055
Merge branch 'main' into use_level_settings
Hailong-am Sep 3, 2024
cabf38a
fix lint
Hailong-am Sep 3, 2024
6776cdc
replace user placeholder when security not enabled
Hailong-am Sep 3, 2024
9dee281
remove version for user level settings
Hailong-am Sep 3, 2024
a5156dc
clean up
Hailong-am Sep 3, 2024
6689ff4
Merge remote-tracking branch 'upstream/main' into use_level_settings
Hailong-am Sep 3, 2024
ee9dd6d
Merge branch 'main' into use_level_settings
Hailong-am Sep 4, 2024
cf755c8
add customized render for permissions column
Hailong-am Sep 4, 2024
0482438
Merge branch 'main' into use_level_settings
Hailong-am Sep 4, 2024
87ef0b9
Merge remote-tracking branch 'upstream/main' into use_level_settings
Hailong-am Sep 5, 2024
f40d9b5
address review comments
Hailong-am Sep 5, 2024
88019a6
Merge remote-tracking branch 'upstream/main' into use_level_settings
Hailong-am Sep 5, 2024
9d2cc6e
address review comment
Hailong-am Sep 5, 2024
28e0135
Merge branch 'main' into use_level_settings
Hailong-am Sep 5, 2024
06d29b8
add scope to ui settings route as query parameter
Hailong-am Sep 5, 2024
d856c5e
Merge remote-tracking branch 'upstream/main' into use_level_settings
Hailong-am Sep 6, 2024
0043a9b
fix merge issue
Hailong-am Sep 6, 2024
3993fb3
remove version support for user settings
Hailong-am Sep 6, 2024
a50975b
remove refrences from user settings
Hailong-am Sep 6, 2024
b4f5d46
Merge branch 'main' into use_level_settings
Hailong-am Sep 6, 2024
e2dada6
Update src/plugins/advanced_settings/public/management_app/advanced_s…
Hailong-am Sep 6, 2024
099e199
unify PermissionModeId
Hailong-am Sep 6, 2024
37d7afc
Merge branch 'use_level_settings' of https://github.com/Hailong-am/Op…
Hailong-am Sep 6, 2024
5e83f3f
fix ut
Hailong-am Sep 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/7953.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
feat:
- [Workspace] Support user personal settings ([#7953](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7953))
2 changes: 2 additions & 0 deletions src/core/public/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ export {
NavGroupType,
NavGroupStatus,
WorkspaceAttributeWithPermission,
UiSettingScope,
PermissionModeId,
} from '../types';

export {
Expand Down
4 changes: 3 additions & 1 deletion src/core/server/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,8 @@ export {
StringValidation,
StringValidationRegex,
StringValidationRegexString,
CURRENT_USER_PLACEHOLDER,
UiSettingScope,
} from './ui_settings';

export {
Expand All @@ -369,7 +371,7 @@ export {
MetricsServiceStart,
} from './metrics';

export { AppCategory, WorkspaceAttribute } from '../types';
export { AppCategory, WorkspaceAttribute, PermissionModeId } from '../types';
export { DEFAULT_APP_CATEGORIES, WORKSPACE_TYPE, DEFAULT_NAV_GROUPS } from '../utils';

export {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ describe('uiSettings/createOrUpgradeSavedConfig', function () {
Object {
"newVersion": "4.0.1",
"prevVersion": "4.0.0",
"scope": undefined,
},
],
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,25 +35,33 @@
import { Logger } from '../../logging';

import { getUpgradeableConfig } from './get_upgradeable_config';
import { UiSettingScope } from '../types';
import { generateDocId } from '../utils';

interface Options {
savedObjectsClient: SavedObjectsClientContract;
version: string;
buildNum: number;
log: Logger;
handleWriteErrors: boolean;
scope?: UiSettingScope;
}

export async function createOrUpgradeSavedConfig(
options: Options
): Promise<Record<string, any> | undefined> {
const { savedObjectsClient, version, buildNum, log, handleWriteErrors } = options;
const { savedObjectsClient, version, buildNum, log, handleWriteErrors, scope } = options;

// try to find an older config we can upgrade
const upgradeableConfig = await getUpgradeableConfig({
savedObjectsClient,
version,
});
let upgradeableConfig;
if (scope === UiSettingScope.USER) {
upgradeableConfig = undefined;

Check warning on line 58 in src/core/server/ui_settings/create_or_upgrade_saved_config/create_or_upgrade_saved_config.ts

View check run for this annotation

Codecov / codecov/patch

src/core/server/ui_settings/create_or_upgrade_saved_config/create_or_upgrade_saved_config.ts#L58

Added line #L58 was not covered by tests
} else {
upgradeableConfig = await getUpgradeableConfig({
savedObjectsClient,
version,
});
}

// default to the attributes of the upgradeableConfig if available
const attributes = defaults(
Expand All @@ -62,8 +70,9 @@
);

try {
const docId = generateDocId(version, scope);
// create the new SavedConfig
await savedObjectsClient.create('config', attributes, { id: version });
await savedObjectsClient.create('config', attributes, { id: docId });
} catch (error) {
if (handleWriteErrors) {
if (SavedObjectsErrorHelpers.isConflictError(error)) {
Expand All @@ -85,6 +94,7 @@
log.debug(`Upgrade config from ${upgradeableConfig.id} to ${version}`, {
prevVersion: upgradeableConfig.id,
newVersion: version,
scope,
});
}
}
3 changes: 3 additions & 0 deletions src/core/server/ui_settings/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,7 @@ export {
StringValidation,
StringValidationRegex,
StringValidationRegexString,
UiSettingScope,
} from './types';

export { CURRENT_USER_PLACEHOLDER } from './utils';
10 changes: 9 additions & 1 deletion src/core/server/ui_settings/routes/delete.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,17 @@
import { IRouter } from '../../http';
import { SavedObjectsErrorHelpers } from '../../saved_objects';
import { CannotOverrideError } from '../ui_settings_errors';
import { UiSettingScope } from '../types';

const validate = {
params: schema.object({
key: schema.string(),
}),
query: schema.object({
scope: schema.maybe(
schema.oneOf([schema.literal(UiSettingScope.GLOBAL), schema.literal(UiSettingScope.USER)])
),
}),
};

export function registerDeleteRoute(router: IRouter) {
Expand All @@ -47,7 +53,9 @@
try {
const uiSettingsClient = context.core.uiSettings.client;

await uiSettingsClient.remove(request.params.key);
const { scope } = request.query;

Check warning on line 56 in src/core/server/ui_settings/routes/delete.ts

View check run for this annotation

Codecov / codecov/patch

src/core/server/ui_settings/routes/delete.ts#L56

Added line #L56 was not covered by tests

await uiSettingsClient.remove(request.params.key, scope);

Check warning on line 58 in src/core/server/ui_settings/routes/delete.ts

View check run for this annotation

Codecov / codecov/patch

src/core/server/ui_settings/routes/delete.ts#L58

Added line #L58 was not covered by tests

return response.ok({
body: {
Expand Down
16 changes: 14 additions & 2 deletions src/core/server/ui_settings/routes/get.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,18 +28,30 @@
* under the License.
*/

import { schema } from '@osd/config-schema';

import { IRouter } from '../../http';
import { SavedObjectsErrorHelpers } from '../../saved_objects';
import { UiSettingScope } from '../types';

const validate = {
query: schema.object({
scope: schema.maybe(
schema.oneOf([schema.literal(UiSettingScope.GLOBAL), schema.literal(UiSettingScope.USER)])
),
}),
};

export function registerGetRoute(router: IRouter) {
router.get(
{ path: '/api/opensearch-dashboards/settings', validate: false },
{ path: '/api/opensearch-dashboards/settings', validate },
async (context, request, response) => {
try {
const uiSettingsClient = context.core.uiSettings.client;
const { scope } = request.query;

Check warning on line 51 in src/core/server/ui_settings/routes/get.ts

View check run for this annotation

Codecov / codecov/patch

src/core/server/ui_settings/routes/get.ts#L51

Added line #L51 was not covered by tests
return response.ok({
body: {
settings: await uiSettingsClient.getUserProvided(),
settings: await uiSettingsClient.getUserProvided(scope),
},
});
} catch (error) {
Expand Down
11 changes: 9 additions & 2 deletions src/core/server/ui_settings/routes/set.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import { IRouter } from '../../http';
import { SavedObjectsErrorHelpers } from '../../saved_objects';
import { CannotOverrideError } from '../ui_settings_errors';
import { UiSettingScope } from '../types';

const validate = {
params: schema.object({
Expand All @@ -41,6 +42,11 @@
body: schema.object({
value: schema.any(),
}),
query: schema.object({
scope: schema.maybe(
schema.oneOf([schema.literal(UiSettingScope.GLOBAL), schema.literal(UiSettingScope.USER)])
),
}),
};

export function registerSetRoute(router: IRouter) {
Expand All @@ -52,12 +58,13 @@

const { key } = request.params;
const { value } = request.body;
const { scope } = request.query;

Check warning on line 61 in src/core/server/ui_settings/routes/set.ts

View check run for this annotation

Codecov / codecov/patch

src/core/server/ui_settings/routes/set.ts#L61

Added line #L61 was not covered by tests

await uiSettingsClient.set(key, value);
await uiSettingsClient.set(key, value, scope);

Check warning on line 63 in src/core/server/ui_settings/routes/set.ts

View check run for this annotation

Codecov / codecov/patch

src/core/server/ui_settings/routes/set.ts#L63

Added line #L63 was not covered by tests

return response.ok({
body: {
settings: await uiSettingsClient.getUserProvided(),
settings: await uiSettingsClient.getUserProvided(scope),
},
});
} catch (error) {
Expand Down
11 changes: 9 additions & 2 deletions src/core/server/ui_settings/routes/set_many.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,17 @@
import { IRouter } from '../../http';
import { SavedObjectsErrorHelpers } from '../../saved_objects';
import { CannotOverrideError } from '../ui_settings_errors';
import { UiSettingScope } from '../types';

const validate = {
body: schema.object({
changes: schema.object({}, { unknowns: 'allow' }),
}),
query: schema.object({
scope: schema.maybe(
schema.oneOf([schema.literal(UiSettingScope.GLOBAL), schema.literal(UiSettingScope.USER)])
),
}),
};

export function registerSetManyRoute(router: IRouter) {
Expand All @@ -48,12 +54,13 @@
const uiSettingsClient = context.core.uiSettings.client;

const { changes } = request.body;
const { scope } = request.query;

Check warning on line 57 in src/core/server/ui_settings/routes/set_many.ts

View check run for this annotation

Codecov / codecov/patch

src/core/server/ui_settings/routes/set_many.ts#L57

Added line #L57 was not covered by tests

await uiSettingsClient.setMany(changes);
await uiSettingsClient.setMany(changes, scope);

Check warning on line 59 in src/core/server/ui_settings/routes/set_many.ts

View check run for this annotation

Codecov / codecov/patch

src/core/server/ui_settings/routes/set_many.ts#L59

Added line #L59 was not covered by tests

return response.ok({
body: {
settings: await uiSettingsClient.getUserProvided(),
settings: await uiSettingsClient.getUserProvided(scope),
},
});
} catch (error) {
Expand Down
24 changes: 16 additions & 8 deletions src/core/server/ui_settings/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,12 @@
*/

import { SavedObjectsClientContract } from '../saved_objects/types';
import { UiSettingsParams, UserProvidedValues, PublicUiSettingsParams } from '../../types';
import {
UiSettingsParams,
UserProvidedValues,
PublicUiSettingsParams,
UiSettingScope,
} from '../../types';
export {
UiSettingsParams,
PublicUiSettingsParams,
Expand All @@ -40,6 +45,7 @@ export {
ImageValidation,
UiSettingsType,
UserProvidedValues,
UiSettingScope,
} from '../../types';

/**
Expand All @@ -66,31 +72,33 @@ export interface IUiSettingsClient {
/**
* Retrieves uiSettings values set by the user with fallbacks to default values if not specified.
*/
get: <T = any>(key: string) => Promise<T>;
get: <T = any>(key: string, scope?: UiSettingScope) => Promise<T>;
/**
* Retrieves a set of all uiSettings values set by the user with fallbacks to default values if not specified.
*/
getAll: <T = any>() => Promise<Record<string, T>>;
getAll: <T = any>(scope?: UiSettingScope) => Promise<Record<string, T>>;
/**
* Retrieves a set of all uiSettings values set by the user.
*/
getUserProvided: <T = any>() => Promise<Record<string, UserProvidedValues<T>>>;
getUserProvided: <T = any>(
scope?: UiSettingScope
) => Promise<Record<string, UserProvidedValues<T>>>;
/**
* Writes multiple uiSettings values and marks them as set by the user.
*/
setMany: (changes: Record<string, any>) => Promise<void>;
setMany: (changes: Record<string, any>, scope?: UiSettingScope) => Promise<void>;
/**
* Writes uiSettings value and marks it as set by the user.
*/
set: (key: string, value: any) => Promise<void>;
set: (key: string, value: any, scope?: UiSettingScope) => Promise<void>;
/**
* Removes uiSettings value by key.
*/
remove: (key: string) => Promise<void>;
remove: (key: string, scope?: UiSettingScope) => Promise<void>;
/**
* Removes multiple uiSettings values by keys.
*/
removeMany: (keys: string[]) => Promise<void>;
removeMany: (keys: string[], scope?: UiSettingScope) => Promise<void>;
/**
* Shows whether the uiSettings value set by the user.
*/
Expand Down
Loading
Loading