Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discover] S3 data connection #7917

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Aug 29, 2024

Description

Update the S3 type config.

This PR contains:

  • Browsing connections, databases, tables
  • Creating a dataset from a table and setting the string correctly.

This PR does NOT:

  • Cache data structures
  • Use session ID for querying
  • Re-add async polling to search interceptor

Issues Resolved

n/a

Screenshot

Screenshot 2024-08-29 at 5 51 31 AM Screenshot 2024-08-29 at 5 52 04 AM Screenshot 2024-08-29 at 5 52 18 AM

Testing the changes

Changelog

  • feat: add S3 data exploration for connections, databases, and tables

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.30%. Comparing base (7a8e427) to head (c8f65bc).
Report is 130 commits behind head on main.

Files with missing lines Patch % Lines
...ery/query_string/dataset_service/lib/index_type.ts 0.00% 4 Missing ⚠️
...ry/query_string/dataset_service/dataset_service.ts 0.00% 1 Missing ⚠️
...y_string/dataset_service/lib/index_pattern_type.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7917      +/-   ##
==========================================
- Coverage   64.30%   64.30%   -0.01%     
==========================================
  Files        3673     3674       +1     
  Lines       81126    81134       +8     
  Branches    12928    12926       -2     
==========================================
+ Hits        52171    52172       +1     
- Misses      25744    25751       +7     
  Partials     3211     3211              
Flag Coverage Δ
Linux_1 30.21% <0.00%> (-0.01%) ⬇️
Linux_2 56.19% <ø> (-0.01%) ⬇️
Linux_3 40.61% <0.00%> (-0.01%) ⬇️
Linux_4 31.40% <0.00%> (-0.01%) ⬇️
Windows_1 30.23% <0.00%> (-0.01%) ⬇️
Windows_2 56.14% <ø> (-0.01%) ⬇️
Windows_3 40.61% <0.00%> (-0.01%) ⬇️
Windows_4 31.40% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

timer(0, 5000)
.pipe(
mergeMap(() =>
http.fetch('../../api/enhancements/datasource/jobs', {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the ../.. needed? and should this be http.get since it's more explicit?

Comment on lines +132 to +135
filter((response) => response.status === 'SUCCESS'),
map((response) => {
if (response.status === 'FAILED') {
throw new Error('Job failed');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failed response shouldn't get here after the filter?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right will clean this up post merge.

@kavilla kavilla merged commit 1f4cbbb into opensearch-project:main Aug 29, 2024
66 of 67 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7917-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1f4cbbb30964ae8fc63137ca443c2b122def9681
# Push it to GitHub
git push --set-upstream origin backport/backport-7917-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7917-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 29, 2024
Update the S3 type config.

This commit does:
    Browsing connections, databases, tables
    Creating a dataset from a table and setting the string correctly.

This commit does NOT:
    Cache data structures
    Use session ID for querying
    Re-add async polling to search interceptor

---------

Signed-off-by: Kawika Avilla <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 1f4cbbb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7917-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1f4cbbb30964ae8fc63137ca443c2b122def9681
# Push it to GitHub
git push --set-upstream origin backport/backport-7917-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7917-to-2.x.

kavilla pushed a commit that referenced this pull request Aug 29, 2024
Update the S3 type config.

This commit does:
    Browsing connections, databases, tables
    Creating a dataset from a table and setting the string correctly.

This commit does NOT:
    Cache data structures
    Use session ID for querying
    Re-add async polling to search interceptor

---------



(cherry picked from commit 1f4cbbb)

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants