Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [discover] S3 data connection #7928

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 1f4cbbb from #7917.

Update the S3 type config.

This commit does:
    Browsing connections, databases, tables
    Creating a dataset from a table and setting the string correctly.

This commit does NOT:
    Cache data structures
    Use session ID for querying
    Re-add async polling to search interceptor

---------

Signed-off-by: Kawika Avilla <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 1f4cbbb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@kavilla kavilla merged commit e99e98d into 2.x Aug 29, 2024
55 of 58 checks passed
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.37%. Comparing base (51b5c64) to head (5a0023a).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ery/query_string/dataset_service/lib/index_type.ts 0.00% 4 Missing ⚠️
...ry/query_string/dataset_service/dataset_service.ts 0.00% 1 Missing ⚠️
...y_string/dataset_service/lib/index_pattern_type.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7928      +/-   ##
==========================================
- Coverage   64.37%   64.37%   -0.01%     
==========================================
  Files        3659     3659              
  Lines       80794    80793       -1     
  Branches    12865    12865              
==========================================
- Hits        52014    52013       -1     
  Misses      25591    25591              
  Partials     3189     3189              
Flag Coverage Δ
Linux_1 30.32% <0.00%> (-0.01%) ⬇️
Linux_2 56.15% <ø> (ø)
Linux_3 40.80% <0.00%> (-0.01%) ⬇️
Linux_4 31.62% <0.00%> (-0.01%) ⬇️
Windows_1 30.34% <0.00%> (-0.01%) ⬇️
Windows_2 56.10% <ø> (ø)
Windows_3 40.80% <0.00%> (-0.01%) ⬇️
Windows_4 31.62% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports discover for discover reinvent discover-next failed changeset v2.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants