[discover] Query editor UI clean up

[abbyhu2000]

Description

• register query reference control when registering the language
• make toggle and saved query management part of editor, not query control

Issues Resolved

Screenshot

Testing the changes

Changelog

• fix: Query editor UI clean up

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[github-actions]

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

[kavilla]

i see from my earlier comment.

This is already a lot cleaner so def want this in but I think we can think bigger similar to @joshuali925 stuff with the query header extension being a container this could be the same. And I think the naming will help because i was a little confused before.

We could make this more generic. Will comment in my overall thread.

[kavilla]

Looks a lot cleaner. Thank you so much.

I think we can make it more generic. This is more like query editor actions that developers can register to. Or we can just have a container of queryEditorActions which then lets developers pass any or none in.

But this goes to ensuring the editor is exposed correctly to be reused with the correct state.

Not blocking but i think post 2.17 we should revisit and making it more generic that the editors are exposed and registered completely in the language.

[kavilla]

can you make sure the changelog section is accurate

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7896-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fd8af76ae1327f96f7b7058f24296900bd5817b0
# Push it to GitHub
git push --set-upstream origin backport/backport-7896-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7896-to-2.x.