Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual backport 2.x] [discover] Query editor UI clean up (#7896) #7902

Merged

Conversation

abbyhu2000
Copy link
Member

Description

Manual backport of #7896

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

* follow up

Signed-off-by: abbyhu2000 <[email protected]>

* address comments

Signed-off-by: abbyhu2000 <[email protected]>

* Changeset file for PR opensearch-project#7896 created/updated

---------

Signed-off-by: abbyhu2000 <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@abbyhu2000 abbyhu2000 added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.32%. Comparing base (3c5a506) to head (ea96379).
Report is 4 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ng/language_service/default_language_reference.tsx 27.27% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7902      +/-   ##
==========================================
- Coverage   64.34%   64.32%   -0.02%     
==========================================
  Files        3658     3659       +1     
  Lines       80842    80854      +12     
  Branches    12880    12880              
==========================================
- Hits        52016    52011       -5     
- Misses      25635    25652      +17     
  Partials     3191     3191              
Flag Coverage Δ
Linux_1 30.31% <14.28%> (-0.01%) ⬇️
Linux_2 56.04% <ø> (ø)
Linux_3 40.77% <42.85%> (+<0.01%) ⬆️
Linux_4 31.59% <14.28%> (-0.01%) ⬇️
Windows_1 ?
Windows_2 55.99% <ø> (ø)
Windows_3 40.77% <42.85%> (+<0.01%) ⬆️
Windows_4 31.59% <14.28%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abbyhu2000 abbyhu2000 merged commit e886b27 into opensearch-project:2.x Aug 29, 2024
64 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed changeset Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants