fix(queryAssist): allow dataset with DATA_SOURCE type
#7890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <[email protected]>
joshuali925
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi and
sejli
as code owners
github-actions
bot
added
seasoned-contributor
Skip-Changelog
Signed-off-by: Joshua Li <[email protected]>
ashwin-pc
approved these changes
Aug 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7890 +/- ##
==========================================
- Coverage 64.21% 64.21% -0.01%
==========================================
Files 3673 3673
Lines 81177 81185 +8
Branches 12941 12943 +2
==========================================
+ Hits 52129 52130 +1
- Misses 25840 25847 +7
Partials 3208 3208
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sejli
approved these changes
Aug 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
* fix(queryAssist): allow dataset with DATA_SOURCE type Signed-off-by: Joshua Li <[email protected]> * prevent multiple calls to get available languages Signed-off-by: Joshua Li <[email protected]> --------- Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 8033aa4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuali925
pushed a commit
that referenced
this pull request
Aug 28, 2024
* fix(queryAssist): allow dataset with DATA_SOURCE type * prevent multiple calls to get available languages --------- (cherry picked from commit 8033aa4) Signed-off-by: Joshua Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows query assist to show up on indices from supported datasource and prevents multiple calls to get available languages
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration