Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] fix(queryAssist): allow dataset with DATA_SOURCE type #7892

Merged
merged 1 commit into from
Aug 28, 2024
Merged

[Backport 2.x] fix(queryAssist): allow dataset with DATA_SOURCE type #7892

merged 1 commit into from
Aug 28, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 8033aa4 from #7890.

@github-actions
fix(queryAssist): allow dataset with DATA_SOURCE type (#7890)
2fbc5c5 
* fix(queryAssist): allow dataset with DATA_SOURCE type

Signed-off-by: Joshua Li <[email protected]>

* prevent multiple calls to get available languages

Signed-off-by: Joshua Li <[email protected]>

---------

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 8033aa4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added autocut Skip the changelog verification check on backports Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry seasoned-contributor v2.17.0 labels Aug 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@github-actions github-actions bot removed the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Aug 28, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 64.26%. Comparing base (a9e7068) to head (2fbc5c5).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...nts/public/query_assist/utils/create_extension.tsx 9.09% 10 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #7892      +/-   ##
==========================================
- Coverage   64.26%   64.26%   -0.01%     
==========================================
  Files        3659     3659              
  Lines       80813    80821       +8     
  Branches    12867    12869       +2     
==========================================
+ Hits        51938    51939       +1     
- Misses      25692    25699       +7     
  Partials     3183     3183
Flag Coverage Δ
Linux_1 30.32% <ø> (ø)
Linux_2 56.04% <ø> (ø)
Linux_3 40.70% <ø> (ø)
Linux_4 31.54% <9.09%> (-0.01%) ⬇️
Windows_1 30.34% <ø> (ø)
Windows_2 55.99% <ø> (ø)
Windows_3 40.70% <ø> (ø)
Windows_4 31.54% <9.09%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuali925 joshuali925 merged commit e8683ca into 2.x Aug 28, 2024
67 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuali925 joshuali925 joshuali925 approved these changes

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports failed changeset seasoned-contributor v2.17.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashwin-pc @joshuali925