Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation] Left navigation collective #7655

Merged
merged 29 commits into from
Aug 16, 2024

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Aug 8, 2024

Description

The PR is to fix some issues:

  • Change category to manage workspace.
  • Move visualization to all use case.
  • Change the scrollable area of left navigation.
  • Move index patterns management to settings and setup.
  • Change the top icon behavior.
  • Use gap to add margin to icons in bottom container.
  • Make new nav work in mobile
  • Add descriptions to some of core apps.
  • Use a smaller font size to display menus.
  • Append navLinks inside second level to custom category if no entry for the nav group

Issues Resolved

Screenshot

Change category to manage workspace

image

Change the scrollable area of left navigation.

20240813183743370.mp4

Change the top icon behavior.

image

Add descriptions to some of core apps.

image

Append navLinks inside second level to custom category if no entry for the nav group

image

Testing the changes

Changelog

  • feat: [navigation] Left navigation collective

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: SuZhou-Joe <[email protected]>
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 80.48780% with 8 lines in your changes missing coverage. Please review.

Project coverage is 63.74%. Comparing base (36af5e7) to head (5352851).
Report is 7 commits behind head on main.

Files Patch % Lines
...gins/workspace/public/services/use_case_service.ts 58.33% 3 Missing and 2 partials ⚠️
...chrome/ui/header/collapsible_nav_group_enabled.tsx 87.50% 0 Missing and 2 partials ⚠️
...me/ui/header/collapsible_nav_group_enabled_top.tsx 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7655      +/-   ##
==========================================
- Coverage   63.75%   63.74%   -0.01%     
==========================================
  Files        3639     3639              
  Lines       80461    80460       -1     
  Branches    12800    12806       +6     
==========================================
- Hits        51297    51290       -7     
- Misses      26028    26077      +49     
+ Partials     3136     3093      -43     
Flag Coverage Δ
Linux_1 29.86% <27.50%> (+0.01%) ⬆️
Linux_2 55.82% <87.50%> (-0.01%) ⬇️
Linux_3 40.39% <0.00%> (-0.01%) ⬇️
Linux_4 31.29% <4.00%> (-0.02%) ⬇️
Windows_1 29.87% <27.50%> (+0.01%) ⬆️
Windows_2 55.77% <87.50%> (-0.01%) ⬇️
Windows_3 40.39% <0.00%> (+<0.01%) ⬆️
Windows_4 31.29% <4.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opensearch-project opensearch-project deleted a comment from github-actions bot Aug 13, 2024
ruanyl
ruanyl previously approved these changes Aug 14, 2024
Copy link
Member

@ruanyl ruanyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor comments

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
ruanyl
ruanyl previously approved these changes Aug 14, 2024
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
ruanyl
ruanyl previously approved these changes Aug 15, 2024
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe SuZhou-Joe merged commit 6877bea into opensearch-project:main Aug 16, 2024
67 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7655-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6877beaadd517207722c261181c1751bfa5bfb40
# Push it to GitHub
git push --set-upstream origin backport/backport-7655-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7655-to-2.x.

SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Aug 16, 2024
* feat: change nav groups

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR opensearch-project#7655 created/updated

* feat: move visualizations to all use case

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: change the scrollable area

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: register manage workspace category when in a workspace

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: register index patterns to settings and setup

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: show correct icon in top

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: use gap to replace margin

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: make new left nav work in mobile mode

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: bootstrap error

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test error

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: justify content

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add descriptions to core features

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add description to index pattern

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: use smaller font size in left nav

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: append navLinks inside second level to custom category if no  entry for the nav group

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: some optimize

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: fix unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: filter all use case

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 6877bea)
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Aug 19, 2024
* feat: change nav groups

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR opensearch-project#7655 created/updated

* feat: move visualizations to all use case

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: change the scrollable area

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: register manage workspace category when in a workspace

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: register index patterns to settings and setup

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: show correct icon in top

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: use gap to replace margin

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: make new left nav work in mobile mode

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: bootstrap error

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test error

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: justify content

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add descriptions to core features

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add description to index pattern

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: use smaller font size in left nav

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: append navLinks inside second level to custom category if no  entry for the nav group

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: some optimize

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: fix unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: filter all use case

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 6877bea)
ananzh pushed a commit that referenced this pull request Aug 19, 2024
* feat: change nav groups

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR #7655 created/updated

* feat: move visualizations to all use case

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: change the scrollable area

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: register manage workspace category when in a workspace

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: register index patterns to settings and setup

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: show correct icon in top

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: use gap to replace margin

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: make new left nav work in mobile mode

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: bootstrap error

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test error

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: justify content

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add descriptions to core features

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add description to index pattern

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: use smaller font size in left nav

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: append navLinks inside second level to custom category if no  entry for the nav group

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: some optimize

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: fix unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: filter all use case

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 6877bea)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants