Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [navigation] Left navigation collective #7728

Merged

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Aug 16, 2024

Description

Manualy backport 6877bea from #7655

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 80.48780% with 8 lines in your changes missing coverage. Please review.

Project coverage is 63.80%. Comparing base (f1f14c9) to head (902d073).
Report is 396 commits behind head on 2.x.

Files with missing lines Patch % Lines
...gins/workspace/public/services/use_case_service.ts 58.33% 3 Missing and 2 partials ⚠️
...chrome/ui/header/collapsible_nav_group_enabled.tsx 87.50% 0 Missing and 2 partials ⚠️
...me/ui/header/collapsible_nav_group_enabled_top.tsx 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7728      +/-   ##
==========================================
- Coverage   63.81%   63.80%   -0.01%     
==========================================
  Files        3646     3646              
  Lines       80751    80750       -1     
  Branches    12842    12848       +6     
==========================================
- Hits        51528    51521       -7     
- Misses      26067    26070       +3     
- Partials     3156     3159       +3     
Flag Coverage Δ
Linux_1 29.90% <27.50%> (+0.01%) ⬆️
Linux_2 55.94% <87.50%> (-0.01%) ⬇️
Linux_3 40.51% <0.00%> (-0.01%) ⬇️
Linux_4 31.45% <4.00%> (-0.02%) ⬇️
Windows_1 29.91% <27.50%> (+0.01%) ⬆️
Windows_2 55.89% <87.50%> (-0.01%) ⬇️
Windows_3 40.52% <0.00%> (+<0.01%) ⬆️
Windows_4 31.45% <4.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* feat: change nav groups

Signed-off-by: SuZhou-Joe <[email protected]>

* Changeset file for PR opensearch-project#7655 created/updated

* feat: move visualizations to all use case

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: change the scrollable area

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: register manage workspace category when in a workspace

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: register index patterns to settings and setup

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: show correct icon in top

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: use gap to replace margin

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: make new left nav work in mobile mode

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: bootstrap error

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test error

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: justify content

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add descriptions to core features

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add description to index pattern

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: use smaller font size in left nav

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: append navLinks inside second level to custom category if no  entry for the nav group

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: some optimize

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: fix unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: filter all use case

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 6877bea)
@SuZhou-Joe SuZhou-Joe force-pushed the backport/backport-7655-to-2.x branch from 8f75552 to 902d073 Compare August 19, 2024 02:18
@ananzh ananzh merged commit 4a7375b into opensearch-project:2.x Aug 19, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
navigation Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants