-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] [navigation] Left navigation collective #7728
Merged
ananzh
merged 1 commit into
opensearch-project:2.x
from
SuZhou-Joe:backport/backport-7655-to-2.x
Aug 19, 2024
Merged
[Backport 2.x] [navigation] Left navigation collective #7728
ananzh
merged 1 commit into
opensearch-project:2.x
from
SuZhou-Joe:backport/backport-7655-to-2.x
Aug 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuZhou-Joe
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
August 16, 2024 04:18
github-actions
bot
added
the
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
label
Aug 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7728 +/- ##
==========================================
- Coverage 63.81% 63.80% -0.01%
==========================================
Files 3646 3646
Lines 80751 80750 -1
Branches 12842 12848 +6
==========================================
- Hits 51528 51521 -7
- Misses 26067 26070 +3
- Partials 3156 3159 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* feat: change nav groups Signed-off-by: SuZhou-Joe <[email protected]> * Changeset file for PR opensearch-project#7655 created/updated * feat: move visualizations to all use case Signed-off-by: SuZhou-Joe <[email protected]> * feat: change the scrollable area Signed-off-by: SuZhou-Joe <[email protected]> * feat: register manage workspace category when in a workspace Signed-off-by: SuZhou-Joe <[email protected]> * feat: register index patterns to settings and setup Signed-off-by: SuZhou-Joe <[email protected]> * feat: show correct icon in top Signed-off-by: SuZhou-Joe <[email protected]> * feat: use gap to replace margin Signed-off-by: SuZhou-Joe <[email protected]> * feat: make new left nav work in mobile mode Signed-off-by: SuZhou-Joe <[email protected]> * fix: bootstrap error Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test error Signed-off-by: SuZhou-Joe <[email protected]> * feat: justify content Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test Signed-off-by: SuZhou-Joe <[email protected]> * feat: add descriptions to core features Signed-off-by: SuZhou-Joe <[email protected]> * feat: add description to index pattern Signed-off-by: SuZhou-Joe <[email protected]> * feat: use smaller font size in left nav Signed-off-by: SuZhou-Joe <[email protected]> * feat: append navLinks inside second level to custom category if no entry for the nav group Signed-off-by: SuZhou-Joe <[email protected]> * feat: some optimize Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize code Signed-off-by: SuZhou-Joe <[email protected]> * feat: fix unit test Signed-off-by: SuZhou-Joe <[email protected]> * feat: filter all use case Signed-off-by: SuZhou-Joe <[email protected]> * fix: unit test Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 6877bea)
SuZhou-Joe
force-pushed
the
backport/backport-7655-to-2.x
branch
from
August 19, 2024 02:18
8f75552
to
902d073
Compare
ruanyl
approved these changes
Aug 19, 2024
ananzh
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manualy backport 6877bea from #7655
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration