Skip to content

Commit

Permalink
Merge pull request #47 from brianhlin/htcondorce209
Browse files Browse the repository at this point in the history
Temporary fix to handle broken CE 2.0.8 to 2.0.9 updates
  • Loading branch information
matyasselmeci authored Sep 29, 2016
2 parents abd43b7 + 1daa664 commit 7b0d304
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 5 deletions.
20 changes: 17 additions & 3 deletions osgtest/tests/test_19_condorce.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,26 @@ def test_05_start_condorce(self):
core.state['condor-ce.schedd-ready'] = False

core.skip_ok_unless_installed('condor', 'htcondor-ce', 'htcondor-ce-client')
self.skip_ok_if(service.is_running('condor-ce'), 'already running')
service.start('condor-ce')

collector_log, _, _ = core.check_system(('condor_ce_config_val', 'COLLECTOR_LOG'),
'Failed to query for Condor CE CollectorLog path')
core.config['condor-ce.collectorlog'] = collector_log.strip().strip()

if service.is_running('condor-ce'):
# Required to accept changes to the mapfile, which caused
# issues in the nightly due to bad htcondor-ce-2.0.8-2
# packaging remove after OSG 3.3.17. We don't use service.stop()
# because it only stops services that we've started
if core.el_release() < 7:
command = ('service', 'condor-ce', 'stop')
else:
command = ('systemctl', 'stop', 'condor-ce')
core.check_system(command, 'Stop condor-ce service')
service.start('condor-ce')

core.state['condor-ce.schedd-ready'] = True
self.skip_ok('already running')
service.start('condor-ce')

try:
stat = os.stat(core.config['condor-ce.collectorlog'])
except OSError:
Expand Down
3 changes: 2 additions & 1 deletion osgtest/tests/test_41_jobs.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import tempfile

import osgtest.library.core as core
import osgtest.library.service as service
import osgtest.library.osgunittest as osgunittest

class TestRunJobs(osgunittest.OSGTestCase):
Expand Down Expand Up @@ -97,7 +98,7 @@ def test_04_condor_run_pbs(self):
def test_05_condor_ce_run_condor(self):
core.skip_ok_unless_installed('htcondor-ce', 'htcondor-ce-client', 'htcondor-ce-condor', 'condor')

self.skip_bad_unless(core.state['condor-ce.started-service'], 'ce not started')
self.skip_bad_unless(service.is_running('condor-ce'), 'ce not running')
self.skip_bad_unless(core.state['jobs.env-set'], 'job environment not set')

command = ('condor_ce_run', '-r', '%s:9619' % core.get_hostname(), '/bin/env')
Expand Down
2 changes: 1 addition & 1 deletion osgtest/tests/test_55_condorce.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
class TestCondorCE(osgunittest.OSGTestCase):
def general_requirements(self):
core.skip_ok_unless_installed('condor', 'htcondor-ce', 'htcondor-ce-client')
self.skip_bad_unless(core.state['condor-ce.started-service'], 'ce not running')
self.skip_bad_unless(service.is_running('condor-ce'), 'ce not running')

def test_01_status(self):
self.general_requirements()
Expand Down

0 comments on commit 7b0d304

Please sign in to comment.