-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully remove part provider and last remaining references #401
Merged
timtebeek
merged 8 commits into
openrewrite:main
from
Mgonzalez-droid:Fully-remove-PartProvider-and-last-remaining-references
Feb 3, 2024
Merged
Fully remove part provider and last remaining references #401
timtebeek
merged 8 commits into
openrewrite:main
from
Mgonzalez-droid:Fully-remove-PartProvider-and-last-remaining-references
Feb 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
reviewed
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this started! I've posted a suggestion that I'll apply to ensure we keep the original arguments.
src/main/java/org/openrewrite/java/migrate/util/MigrateCollectionsSingletonList.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Jan 23, 2024
src/main/java/org/openrewrite/java/migrate/util/MigrateCollectionsSingletonList.java
Outdated
Show resolved
Hide resolved
This was referenced Jan 23, 2024
Merged
Saving future self and others a click: We still need to fix types on the use of
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Remove deprecated code in place for new functionality.
What's your motivation?
openrewrite/rewrite#3754 (comment)
Anything in particular you'd like reviewers to focus on?
Is not a complete implementation due to time constraints, will be able to complete any final changes as needed. Not tested with build.
Anyone you would like to review specifically?
@timtebeek
Have you considered any alternatives or workarounds?
N/A
Any additional context
N/A
Checklist