Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully remove part provider and last remaining references #401

Conversation

Mgonzalez-droid
Copy link
Contributor

What's changed?

Remove deprecated code in place for new functionality.

What's your motivation?

openrewrite/rewrite#3754 (comment)

Anything in particular you'd like reviewers to focus on?

Is not a complete implementation due to time constraints, will be able to complete any final changes as needed. Not tested with build.

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

N/A

Any additional context

N/A

Checklist

  • [ No] I've added unit tests to cover both positive and negative cases
  • [ No] I've read and applied the recipe conventions and best practices
  • [No ] I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek self-requested a review January 23, 2024 09:24
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this started! I've posted a suggestion that I'll apply to ensure we keep the original arguments.

@timtebeek
Copy link
Contributor

Saving future self and others a click: We still need to fix types on the use of List.of for this case.

MigrateCollectionsSingletonListTest > templateError() FAILED
    java.lang.IllegalStateException: LST contains missing or invalid type information
    MethodInvocation->MethodInvocation->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit
    /*~~(MethodInvocation type is missing or malformed)~~>*/List.of(new ConnectionListener() {
             @Override
             public void onCreate() {
             }
         })
        at org.openrewrite.java.Assertions.assertValidTypes(Assertions.java:87)
        at org.openrewrite.java.Assertions.validateTypes(Assertions.java:57)
        at org.openrewrite.java.Assertions$$Lambda$622/0x00007f7dc0316468.accept(Unknown Source)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:497)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:132)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:127)
        at org.openrewrite.java.migrate.util.MigrateCollectionsSingletonListTest.templateError(MigrateCollectionsSingletonListTest.java:38)

@timtebeek timtebeek added the enhancement New feature or request label Jan 24, 2024
@timtebeek timtebeek merged commit 75000d1 into openrewrite:main Feb 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants