Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully remove part provider and last remaining references #3944

Conversation

Mgonzalez-droid
Copy link
Contributor

@Mgonzalez-droid Mgonzalez-droid commented Jan 22, 2024

What's changed?

Remove deprecated code in place for new functionality.

What's your motivation?

#3754 (comment)

Anything in particular you'd like reviewers to focus on?

Is not a complete implementation due to time constraints, will be able to complete any final changes as needed. Not tested with build.

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

N/A

Any additional context

N/A

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek self-requested a review January 23, 2024 09:31
@timtebeek
Copy link
Contributor

Thanks for getting this started @Mgonzalez-droid ! Let's try to get this first one through, and then circle back here:

@timtebeek timtebeek marked this pull request as draft February 5, 2024 11:03
@timtebeek timtebeek removed their request for review February 5, 2024 11:03
@timtebeek timtebeek linked an issue Feb 5, 2024 that may be closed by this pull request
6 tasks
@timtebeek timtebeek added the enhancement New feature or request label Feb 5, 2024
@timtebeek timtebeek marked this pull request as ready for review February 11, 2024 12:18
@timtebeek timtebeek self-requested a review February 11, 2024 12:19
@timtebeek timtebeek merged commit 9b5b734 into openrewrite:main Feb 11, 2024
1 check passed
@timtebeek
Copy link
Contributor

Thanks for the help in getting this started @Mgonzalez-droid !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fully remove PartProvider and last remaining references
2 participants