-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update document.py #1864
Update document.py #1864
Conversation
Fix broken interface. If the URL is None we won't need a multilingual dict like {"de": None} but a real None. This PR is solving the issue
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1864 +/- ##
==========================================
- Coverage 77.73% 77.68% -0.05%
==========================================
Files 127 127
Lines 5268 5271 +3
==========================================
Hits 4095 4095
- Misses 1173 1176 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. As soon as the tests are done for the oereblex data_sources the issues from codecov can be addressed.
I did the additional test which was necessary 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Fix broken interface. If the URL is None we won't need a multilingual dict like {"de": None} but a real None. This PR is solving the issue
This is a followup of #1763 which break the tests 😬