Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update document.py #1864

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Update document.py #1864

merged 2 commits into from
Nov 27, 2023

Conversation

vvmruder
Copy link
Collaborator

@vvmruder vvmruder commented Nov 27, 2023

Fix broken interface. If the URL is None we won't need a multilingual dict like {"de": None} but a real None. This PR is solving the issue

This is a followup of #1763 which break the tests 😬

Fix broken interface. If the URL is None we won't need a multilingual dict like {"de": None} but a real None. This PR is solving the issue
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (031fedf) 77.73% compared to head (567c77c) 77.68%.
Report is 1 commits behind head on master.

Files Patch % Lines
.../contrib/data_sources/oereblex/sources/document.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1864      +/-   ##
==========================================
- Coverage   77.73%   77.68%   -0.05%     
==========================================
  Files         127      127              
  Lines        5268     5271       +3     
==========================================
  Hits         4095     4095              
- Misses       1173     1176       +3     
Flag Coverage Δ
unittests 77.68% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@svamaa svamaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. As soon as the tests are done for the oereblex data_sources the issues from codecov can be addressed.

@vvmruder
Copy link
Collaborator Author

Looks good to me. As soon as the tests are done for the oereblex data_sources the issues from codecov can be addressed.

I did the additional test which was necessary 😆

Copy link
Collaborator

@voisardf voisardf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vvmruder vvmruder merged commit 4a920ad into master Nov 27, 2023
9 of 12 checks passed
@vvmruder vvmruder deleted the vvmruder-patch-1 branch November 27, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants