Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1411 revise documentation #1466

Merged
merged 10 commits into from
Nov 27, 2023
Merged

1411 revise documentation #1466

merged 10 commits into from
Nov 27, 2023

Conversation

voisardf
Copy link
Collaborator

Improving main project documentation regarding architecture, installation, configuration, contributions

@voisardf voisardf added enhancement documentation usergroup work This lable is used to mark issues which will be done by usergroup members labels Jan 11, 2022
@voisardf voisardf self-assigned this Jan 11, 2022
@jwkaltz jwkaltz self-requested a review December 14, 2022 12:48
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a920ad) 77.68% compared to head (58beffb) 77.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1466   +/-   ##
=======================================
  Coverage   77.68%   77.68%           
=======================================
  Files         127      127           
  Lines        5271     5271           
=======================================
  Hits         4095     4095           
  Misses       1176     1176           
Flag Coverage Δ
unittests 77.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@voisardf voisardf marked this pull request as ready for review April 4, 2023 14:12
@voisardf voisardf requested review from vvmruder and jwkaltz April 4, 2023 14:12
@voisardf voisardf requested review from michmuel and svamaa May 5, 2023 07:43
Copy link
Collaborator

@michmuel michmuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks as if the doc provides the most important information. I added a few comments. It would be good if you could fix the rendering. Do the scripts that create the schemes and tables work properly?

doc/source/configuration.rst Outdated Show resolved Hide resolved
doc/source/configuration.rst Outdated Show resolved Hide resolved
doc/source/configuration.rst Outdated Show resolved Hide resolved
doc/source/configuration.rst Outdated Show resolved Hide resolved
doc/source/configuration.rst Outdated Show resolved Hide resolved
doc/source/configuration.rst Show resolved Hide resolved
doc/source/configuration.rst Outdated Show resolved Hide resolved
doc/source/configuration.rst Outdated Show resolved Hide resolved
@voisardf
Copy link
Collaborator Author

@michmuel Thanks for the comments and suggestions!

Copy link
Collaborator

@svamaa svamaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to the tests pipeline? tests for python3.11 fail, but do not show errors. all the other tests are cancelled although no python code has been changed.
Maybe we should merge the current master into the branch?

doc/source/configuration.rst Outdated Show resolved Hide resolved
doc/source/configuration.rst Show resolved Hide resolved
@michmuel
Copy link
Collaborator

@svamaa Thanks for the hint. I was not aware of it, but it is described in https://www.cadastre.ch/content/cadastre-internet/de/manual-oereb/publication/instruction.download/cadastre-internet/de/documents/oereb-weisungen/Weisung-OEREB-XML-Aufruf-de.pdf.

@vvmruder
Copy link
Collaborator

@michmuel could you check if your requested changes were solved propely and remove the "change requested" flag if so?

Copy link
Collaborator

@vvmruder vvmruder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after rework and rebase this looks good to be merged

@vvmruder vvmruder force-pushed the 1411-revise_documentation branch from fc2d499 to 92a3b83 Compare November 27, 2023 10:02
@vvmruder vvmruder force-pushed the 1411-revise_documentation branch from 92a3b83 to 58beffb Compare November 27, 2023 10:43
@vvmruder
Copy link
Collaborator

What happened to the tests pipeline? tests for python3.11 fail, but do not show errors. all the other tests are cancelled although no python code has been changed. Maybe we should merge the current master into the branch?

@svamaa Tests are running again. This was solved by: #1864

@vvmruder vvmruder merged commit aad8382 into master Nov 27, 2023
12 checks passed
@vvmruder vvmruder deleted the 1411-revise_documentation branch November 27, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement usergroup work This lable is used to mark issues which will be done by usergroup members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants