-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1411 revise documentation #1466
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1466 +/- ##
=======================================
Coverage 77.68% 77.68%
=======================================
Files 127 127
Lines 5271 5271
=======================================
Hits 4095 4095
Misses 1176 1176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks as if the doc provides the most important information. I added a few comments. It would be good if you could fix the rendering. Do the scripts that create the schemes and tables work properly?
@michmuel Thanks for the comments and suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened to the tests pipeline? tests for python3.11 fail, but do not show errors. all the other tests are cancelled although no python code has been changed.
Maybe we should merge the current master into the branch?
@svamaa Thanks for the hint. I was not aware of it, but it is described in https://www.cadastre.ch/content/cadastre-internet/de/manual-oereb/publication/instruction.download/cadastre-internet/de/documents/oereb-weisungen/Weisung-OEREB-XML-Aufruf-de.pdf. |
95f1c7d
to
fc2d499
Compare
@michmuel could you check if your requested changes were solved propely and remove the "change requested" flag if so? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after rework and rebase this looks good to be merged
fc2d499
to
92a3b83
Compare
92a3b83
to
58beffb
Compare
Improving main project documentation regarding architecture, installation, configuration, contributions