[sitemap] Add new "staticIcon" parameter #3735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also update https://github.com/openhab/openhab-core/blob/f5a0b37b3dfc2bc188c6f80dca96b91a0fd72b6e/bundles/org.openhab.core.ui/src/main/java/org/openhab/core/ui/internal/components/UIComponentSitemapProvider.java? We can then add support for configuring it in mainUI as well. |
lolodomo
force-pushed
the
sitemap_staticIcon
branch
from
7204c6b
to
980aa3a
Compare
Done |
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this pull request
Jul 31, 2023
When set on a sitemap element, Basic UI ignores the item state when initially requesting the OH icon and do not request it again when the item state is updated. Depends on openhab/openhab-core#3735 Related to openhab/openhab-android#3404 Signed-off-by: Laurent Garnier <[email protected]>
|
@openhab/core-maintainers : a review would be appreciated, it is only 35 new lines. |
When set, the UI should not provide the item state when requestiong the OH icon and should not request again the icon when the item state is updated. Related to openhab/openhab-android#3404 Signed-off-by: Laurent Garnier <[email protected]>
lolodomo
force-pushed
the
sitemap_staticIcon
branch
from
980aa3a
to
79b163a
Compare
|
Ok, changed. |
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this pull request
Aug 9, 2023
When set on a sitemap element, Basic UI ignores the item state when initially requesting the OH icon and do not request it again when the item state is updated. Depends on openhab/openhab-core#3735 Related to openhab/openhab-android#3404 Signed-off-by: Laurent Garnier <[email protected]>
kaikreuzer
approved these changes
Aug 13, 2023
kaikreuzer
pushed a commit
to openhab/openhab-webui
that referenced
this pull request
Sep 9, 2023
When set on a sitemap element, Basic UI ignores the item state when initially requesting the OH icon and do not request it again when the item state is updated. Depends on openhab/openhab-core#3735 Related to openhab/openhab-android#3404 Signed-off-by: Laurent Garnier <[email protected]>
stefan-hoehn
pushed a commit
to stefan-hoehn/openhab-webui
that referenced
this pull request
Sep 23, 2023
When set on a sitemap element, Basic UI ignores the item state when initially requesting the OH icon and do not request it again when the item state is updated. Depends on openhab/openhab-core#3735 Related to openhab/openhab-android#3404 Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Stefan Höhn <[email protected]>
JustinGeorgi
pushed a commit
to JustinGeorgi/openhab-webui
that referenced
this pull request
Sep 24, 2023
When set on a sitemap element, Basic UI ignores the item state when initially requesting the OH icon and do not request it again when the item state is updated. Depends on openhab/openhab-core#3735 Related to openhab/openhab-android#3404 Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: jgeorgi <[email protected]>
JustinGeorgi
pushed a commit
to JustinGeorgi/openhab-webui
that referenced
this pull request
Sep 24, 2023
When set on a sitemap element, Basic UI ignores the item state when initially requesting the OH icon and do not request it again when the item state is updated. Depends on openhab/openhab-core#3735 Related to openhab/openhab-android#3404 Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: jgeorgi <[email protected]>
digitaldan
pushed a commit
to digitaldan/openhab-webui
that referenced
this pull request
Sep 24, 2023
When set on a sitemap element, Basic UI ignores the item state when initially requesting the OH icon and do not request it again when the item state is updated. Depends on openhab/openhab-core#3735 Related to openhab/openhab-android#3404 Signed-off-by: Laurent Garnier <[email protected]>
ghys
pushed a commit
to openhab/openhab-webui
that referenced
this pull request
Sep 30, 2023
Related to openhab/openhab-core#3735 --------- Signed-off-by: Mark Herwege <[email protected]>
lolodomo
added a commit
to lolodomo/openhab-docs
that referenced
this pull request
Nov 12, 2023
Related to openhab/openhab-core#3735 Signed-off-by: Laurent Garnier <[email protected]>
lolodomo
added a commit
to lolodomo/openhab-docs
that referenced
this pull request
Nov 12, 2023
Related to openhab/openhab-core#3735 Signed-off-by: Laurent Garnier <[email protected]>
lolodomo
added a commit
to lolodomo/openhab-docs
that referenced
this pull request
Nov 12, 2023
Related to openhab/openhab-core#3735 Signed-off-by: Laurent Garnier <[email protected]>
lolodomo
added a commit
to lolodomo/openhab-docs
that referenced
this pull request
Nov 12, 2023
Related to openhab/openhab-core#3735 Signed-off-by: Laurent Garnier <[email protected]>
stefan-hoehn
pushed a commit
to openhab/openhab-docs
that referenced
this pull request
Nov 19, 2023
* [sitemap] New parameter staticIcon Related to openhab/openhab-core#3735 Signed-off-by: Laurent Garnier <[email protected]> * Review comment: choosing the icon Signed-off-by: Laurent Garnier <[email protected]> --------- Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When set, the UI should not provide the item state when requestiong the OH icon and should not request again the icon when the item state is updated.
Related to openhab/openhab-android#3404
Signed-off-by: Laurent Garnier [email protected]