[mainui] support staticIcon parameter in sitemap configuration #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #1144: Bundle Size — 15.76MiB (~-0.01%).Metrics (no changes)
Total size by type (2 changes)
|
|
@mherwege : please check that it is compliant with the change that was finally merged. |
|
@lolodomo It should now be compliant with the latest syntax. |
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
mherwege
force-pushed
the
static_icon
branch
from
4774349
to
1ccbf5b
Compare
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
ghys
reviewed
Sep 21, 2023
Comment on lines
14
to
15
| } else if (key === 'staticIcon') { | ||
| } else if (key === 'icon') { |
There was a problem hiding this comment.
This will do nothing in case of key === 'staticIcon' (empty block); is it intended? What's the point of it if so?
There was a problem hiding this comment.
Thanks for noticing, must have thought I was using a Java case statement.
Signed-off-by: Mark Herwege <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to openhab/openhab-core#3735
I will test when openhab/openhab-core#3735 has been merged.