Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve runbundles for CXF upgrade #15473

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Resolve runbundles for CXF upgrade #15473

merged 2 commits into from
Aug 23, 2023

Conversation

wborn
Copy link
Member

@wborn wborn commented Aug 21, 2023

Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already triggered a core build

@wborn
Copy link
Member Author

wborn commented Aug 22, 2023

I will have a look at why the hueemulation test fails.

@wborn wborn requested a review from digitaldan as a code owner August 22, 2023 16:55
…tests

It seems that the Grizzly JAX-RS Client implementation does not work well with the new CXF dependencies on the classpath.
As we do not use Grizzly anywhere else it is probably best to also stop using the Grizzly HTTP Server in these tests in the future.

Signed-off-by: Wouter Born <[email protected]>
@wborn wborn requested a review from a team August 23, 2023 05:26
@J-N-K J-N-K merged commit 626c6bd into openhab:main Aug 23, 2023
2 checks passed
@J-N-K J-N-K added this to the 4.1 milestone Aug 23, 2023
@J-N-K J-N-K added the enhancement An enhancement or new feature for an existing add-on label Aug 23, 2023
@wborn wborn deleted the cxf-3.6.1 branch August 23, 2023 07:17
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Sep 29, 2023
* Resolve runbundles for CXF upgrade

Related to openhab/openhab-core#3770

Signed-off-by: Wouter Born <[email protected]>

* Replace Grizzly JAX-RS Client with Jetty HTTP client in hueemulation tests

It seems that the Grizzly JAX-RS Client implementation does not work well with the new CXF dependencies on the classpath.
As we do not use Grizzly anywhere else it is probably best to also stop using the Grizzly HTTP Server in these tests in the future.

Signed-off-by: Wouter Born <[email protected]>

---------

Signed-off-by: Wouter Born <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
* Resolve runbundles for CXF upgrade

Related to openhab/openhab-core#3770

Signed-off-by: Wouter Born <[email protected]>

* Replace Grizzly JAX-RS Client with Jetty HTTP client in hueemulation tests

It seems that the Grizzly JAX-RS Client implementation does not work well with the new CXF dependencies on the classpath.
As we do not use Grizzly anywhere else it is probably best to also stop using the Grizzly HTTP Server in these tests in the future.

Signed-off-by: Wouter Born <[email protected]>

---------

Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants