-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve runbundles for CXF upgrade #15473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to openhab/openhab-core#3770 Signed-off-by: Wouter Born <[email protected]>
wborn
requested review from
hmerk,
cweitkamp,
kaikreuzer,
svilenvul,
marcelrv,
ssalonen,
davidgraeff,
BjoernLange and
gerrieg
as code owners
August 21, 2023 17:50
J-N-K
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already triggered a core build
hmerk
approved these changes
Aug 21, 2023
I will have a look at why the hueemulation test fails. |
…tests It seems that the Grizzly JAX-RS Client implementation does not work well with the new CXF dependencies on the classpath. As we do not use Grizzly anywhere else it is probably best to also stop using the Grizzly HTTP Server in these tests in the future. Signed-off-by: Wouter Born <[email protected]>
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Sep 29, 2023
* Resolve runbundles for CXF upgrade Related to openhab/openhab-core#3770 Signed-off-by: Wouter Born <[email protected]> * Replace Grizzly JAX-RS Client with Jetty HTTP client in hueemulation tests It seems that the Grizzly JAX-RS Client implementation does not work well with the new CXF dependencies on the classpath. As we do not use Grizzly anywhere else it is probably best to also stop using the Grizzly HTTP Server in these tests in the future. Signed-off-by: Wouter Born <[email protected]> --------- Signed-off-by: Wouter Born <[email protected]>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* Resolve runbundles for CXF upgrade Related to openhab/openhab-core#3770 Signed-off-by: Wouter Born <[email protected]> * Replace Grizzly JAX-RS Client with Jetty HTTP client in hueemulation tests It seems that the Grizzly JAX-RS Client implementation does not work well with the new CXF dependencies on the classpath. As we do not use Grizzly anywhere else it is probably best to also stop using the Grizzly HTTP Server in these tests in the future. Signed-off-by: Wouter Born <[email protected]> --------- Signed-off-by: Wouter Born <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to openhab/openhab-core#3770