Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[transform] Use Java 17 features #15483

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

holgerfriedrich
Copy link
Member

@holgerfriedrich holgerfriedrich commented Aug 23, 2023

instanceof matching and multiline strings

Similar to what we did in core a few month ago. Note that this breaks compatibilty to Java 11.

@holgerfriedrich holgerfriedrich changed the title [transform] Code optimization for Java17 [transform] Use Java 17 features Aug 23, 2023
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
The build issues will probably be resolved after #15473 is merged.

Copy link
Contributor

@clinique clinique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Aug 23, 2023
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerfriedrich
Copy link
Member Author

Jenkins did not complete, tried a rebase to current main. Sorry for doing a force push.

@wborn wborn merged commit 6e49c6e into openhab:main Aug 24, 2023
2 checks passed
@wborn wborn added this to the 4.1 milestone Aug 24, 2023
@holgerfriedrich holgerfriedrich deleted the pr-java17-transform branch August 24, 2023 05:35
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Sep 29, 2023
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
…tiline strings (openhab#15483)

Signed-off-by: Holger Friedrich <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants