Implement geofencing settings in the project properties' QField panel #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice ! Can we have a UI adjustment: the description what it does (i.e. it will alert in case of XXX) should be there. The "reverted logic" should live as a tooltip instead. |
|
@m-kuhn , we can certainly have a UI adjustment ;) good idea. |
nirvn
force-pushed
the
geofencing
branch
5 times, most recently
from
acfb0f8 to
9b06840
Compare
suricactus
reviewed
Jul 9, 2024
| self.geofencingGroupBox.isChecked() | ||
| ) | ||
|
|
||
| try: |
There was a problem hiding this comment.
Do you have a concrete example when we need the try/except? I see it is also 10 lines above, but on this line it seems you handle this with the if/else check for currentLayer() existance.
suricactus
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a couple of widgets to setup geofencing in QField. Looks:
The libqfieldsync counterpart is here: opengisch/libqfieldsync#86