Skip to content

Commit

Permalink
Address review on settings naming
Browse files Browse the repository at this point in the history
  • Loading branch information
nirvn committed Jul 21, 2024
1 parent aca722a commit ea77ad8
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions qfieldsync/gui/project_configuration_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ def reloadProject(self):

# Geofencing settings
self.geofencingGroupBox.setChecked(
self.__project_configuration.geofencing_active
self.__project_configuration.geofencing_is_active
)

geofencingLayer = QgsProject.instance().mapLayer(
Expand All @@ -204,8 +204,8 @@ def reloadProject(self):
)
)

self.geofencingPreventDigitizingCheckBox.setChecked(
self.__project_configuration.geofencing_prevent_digitizing
self.geofencingShouldPreventDigitizingCheckBox.setChecked(
self.__project_configuration.geofencing_should_prevent_digitizing
)

# Advanced settings
Expand Down Expand Up @@ -297,7 +297,7 @@ def apply(self):
pass

# Geofencing settings
self.__project_configuration.geofencing_active = (
self.__project_configuration.geofencing_is_active = (
self.geofencingGroupBox.isChecked()
)

Expand All @@ -314,8 +314,8 @@ def apply(self):
self.geofencingBehaviorComboBox.currentData()
)

self.__project_configuration.geofencing_prevent_digitizing = (
self.geofencingPreventDigitizingCheckBox.isChecked()
self.__project_configuration.geofencing_should_prevent_digitizing = (
self.geofencingShouldPreventDigitizingCheckBox.isChecked()
)

# Advanced settings
Expand Down
2 changes: 1 addition & 1 deletion qfieldsync/ui/project_configuration_widget.ui
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@
<widget class="QComboBox" name="geofencingBehaviorComboBox"/>
</item>
<item row="3" column="0" colspan="2">
<widget class="QCheckBox" name="geofencingPreventDigitizingCheckBox">
<widget class="QCheckBox" name="geofencingShouldPreventDigitizingCheckBox">
<property name="text">
<string>Prevent digitizing when alerting</string>
</property>
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ future
transifex-client

# NOTE `libqfielsync` version should be defined in the `*.tar.gz` format, not `git+https://` to make `wheel` happy
libqfieldsync @ https://github.com/opengisch/libqfieldsync/archive/1fa9ec4a49fe92b67d9dbc69babb1a821e8b3484.tar.gz
libqfieldsync @ https://github.com/opengisch/libqfieldsync/archive/61523b5775dd1bccc25abcf4b9c7a266af18c214.tar.gz

0 comments on commit ea77ad8

Please sign in to comment.